Skip to content

Conversation

@titxue
Copy link
Contributor

@titxue titxue commented Nov 4, 2024

fix(client): fix the logical and login URL path errors for the registry namespace ID

  • Fix the login URL path errors
  • Change the original bitwise OR operator "|" to the logical OR operator "or"- This change ensures that SYS_DEFAULT_NAMESPACE_ID is used only when register_namespace_id is None or empty
  • Previously, the use of the bitwise OR operator may have caused the default value to be used incorrectly when register_namespace_id was 0

fix(client): fix the logical and login URL path errors for the registry namespace ID
- Fix the login URL path errors
- Change the original bitwise OR operator "|" to the logical OR operator "or"- This change ensures that SYS_DEFAULT_NAMESPACE_ID is used only when register_namespace_id is None or empty
- Previously, the use of the bitwise OR operator may have caused the default value to be used incorrectly when register_namespace_id was 0
@damonxue damonxue self-requested a review November 20, 2024 02:49
Copy link
Contributor

@damonxue damonxue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damonxue damonxue merged commit f42dc04 into apache:main Nov 20, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants