Revert recent changes to recoverWith#2674
Conversation
Update Ops.scala revert recent changes to recoverWith
mdedetrich
left a comment
mdedetrich
left a comment
There was a problem hiding this comment.
lgtm
We can reapply the improvements when the behaviour has been certified to be unchanged with tests.
If we do want to change behaviour than Pekko 2.0.x is an opening for that, but it should be intentional and explicit with clear reasoning why
|
Thanks @mdedetrich - it would be my aim to get this backported to 1.5 and appear in the next 1.x release. I agree that on the main branch that we can try to improve the code again but we do need to improve the test coverage to avoid breaking pekko-http http2 tests again. I hope to find some time this week to try to find specifically what is going wrong in pekko-http with the existing changes. I suspect that it is one of the 2 usages of recoverWithRetries that is being affected. |
|
I will revert this if there are objections but in the short term, my aim is to fix the pekko-http build - apache/pekko-http#954 |
* revert recent changes to recoverWith Update Ops.scala revert recent changes to recoverWith * scalafmt
2 participants
see #2620 and apache/pekko-http#954
This keeps tests and doc changes but reverts the Ops.scala changes from #1775 and #2631