HDDS-12136. Allow StorageVolumeChecker to be disabled #9567
+10
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zero, negative values preserved
Russole
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
hdds.datanode.periodic.disk.check.interval.minutes:0is treated as invalid and defaults to60to avoid accidental no-delay scheduling.and logged a warning to make the behavior explicit.
interval with the
@Configannotation default.-1to
0to better represent an explicitly invalid configuration value.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12136
How was this patch tested?
I relied on existing unit and integration tests, and verified that the full CI passed on my fork.
Please let me know if additional tests are needed.