HDDS-12742. Implement pool backed RDBStoreCodecBufferIterator for consistency #9561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swamirishi
force-pushed
the
HDDS-12742_Alt
branch
from
e444138 to
b5dfe25
Compare
…or prefix based iteration Change-Id: I3acf410885571d0b26da9b89a801d9f2f9070e33
…sistency Change-Id: Ieb7a356cde868208f197d55b21889a733575d1dd
swamirishi
force-pushed
the
HDDS-12742_Alt
branch
from
b5dfe25 to
c5743a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently when RDBStoreCodecBufferIterator returns a keyValue to a caller the KeyValue may not be consistent and could have been modified when the next() value is invoked from the iterator. The codecBuffer returned from the first call may have been modified and thus also making this entire Iterator implementation not thread safe.
The proposal here is to have a pool of Buffers and return a closeable handle of KeyValue to the caller which would be only released when the handle to the codec buffers is released.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12742
How was this patch tested?
Added unit test for the new implementation