HDDS-14245. Optimize search for deleted range using prefix count index structure #9560
+1,320
−251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I1cc243d0dadbe647ad9dc7b94822ba7dc6a83e1c
…by abstracting out implementation of each operation Change-Id: Idf5b9a4b9f66eae41a9d832ddbf22e43d1027344
…on for optimization Change-Id: Ia7655ff5148197be488a2c1151ec7fd1d6f9d452
…Operation Change-Id: I4a7c62d8cc91173a1374ba5f3515f3c9ac99376f
…nges and simple logic Change-Id: If659fd2cf71d76909cb81c4362e2e02d85930635
…earch using prefix count index structure Change-Id: I704dab8380d1dd35faa2b9453ef90b439937e95b
adoroszlai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently in prepare batch to verify if an operation is still valid an O(n)check is performed on each and every deleteRange op that has occured after the operation. This is done for each operation in the batch and if all deleteRanges are going to be stacked at the end then the prepare batch can become an O(n2) operation making it unoptimal. This patch aims to create Index data structure to track all the deleteRange operations and provide an efficient way to check if a delete range operation exists or not. The delete ranges would also be popped out of the index structure as and when the delete range op gets executed.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14245
How was this patch tested?
Added unit tests