Skip to content

Conversation

@0lai0
Copy link
Contributor

@0lai0 0lai0 commented Dec 22, 2025

What changes were proposed in this pull request?

This PR updates the NOTICE-ratis-thirdparty-misc.txt file to synchronize it with the latest NOTICE file from the upstream ratis-thirdparty project version 1.0.10.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-12855

Copy link
Contributor

@cchung100m cchung100m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks to @0lai0

@adoroszlai adoroszlai requested a review from szetszwo December 22, 2025 16:07
@adoroszlai adoroszlai changed the title HDDS-12855-Update NOTICE-ratis-thirdparty-misc.txt HDDS-12855. Update NOTICE-ratis-thirdparty-misc.txt Dec 22, 2025
Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0lai0 , thanks for working on this!

Just a question -- is NOTICE-ratis-thirdparty-misc.txt supposed to be the same as https://github.com/apache/ratis-thirdparty/blob/1.0.10/NOTICE ?

@adoroszlai
Copy link
Contributor

is NOTICE-ratis-thirdparty-misc.txt supposed to be the same as https://github.com/apache/ratis-thirdparty/blob/1.0.10/NOTICE ?

I guess it should be like NOTICE in ratis-thirdparty binary, which contains the ratis-thirdparty source NOTICE, and lists bundled dependencies, too:

Apache Ratis Thirdparty Miscellaneous
Copyright 2017-2025 The Apache Software Foundation


This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
---

This product bundles protobuf-java which includes the following:

Copyright 2008 Google Inc.

---

This product bundles gRPC which includes the following text:

Copyright 2014 The gRPC Authors

---

This product bundles Netty which includes the following text:

Copyright 2014 The Netty Project

---

This product bundles Gson which includes the following text:

Copyright 2008 Google Inc.

(This is in misc/target/classes/META-INF/NOTICE after a build.)

Based on that, it LGTM.

@szetszwo
Copy link
Contributor

How the bundled dependencies are selected? Why the other bundled dependencies (such as guava) are not selected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants