HDDS-14209. Reduce parameter count in ObjectEndpoint #9532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
added
s3
Contributor
|
Thanks for the patch @adoroszlai ! |
rich7420
reviewed
Dec 20, 2025
| throws IOException, OS3Exception { | ||
| CompleteMultipartUploadRequest multipartUploadRequest | ||
| ) throws IOException, OS3Exception { | ||
| final String uploadID = getQueryParam(QueryParams.UPLOAD_ID); |
Contributor
There was a problem hiding this comment.
Although underlying checkNotNull throws exception, it returns NullPointerException, not S3 standard error.
Should we add validation here?
Suggested change
| final String uploadID = getQueryParam(QueryParams.UPLOAD_ID); | |
| final String uploadID = getQueryParam(QueryParams.UPLOAD_ID); | |
| if (StringUtils.isEmpty(uploadID)) { | |
| throw newError(INVALID_ARGUMENT, key, | |
| new IllegalArgumentException("uploadId is required")); | |
| } |
Contributor
There was a problem hiding this comment.
plz correct me if I'm wrong.
Contributor
Author
There was a problem hiding this comment.
Thanks, updated.
Contributor
Author
|
Converted to draft and implementing HDDS-14221 first, to reduce changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Similar to #9528: reduce parameter count in
ObjectEndpointrequest handlers by getting query parameters from the request context.https://issues.apache.org/jira/browse/HDDS-14209
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/20379663044