ORC-1891: Upgrade to Apache parent pom 34 #2341
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you for making a quick PR, @vrozov .
@williamhyun made a PR to have a test coverage to prevent the same mistake.
Could you rebase this PR to the main branch once more because #2340 is merged now, @vrozov ?
Member
|
Oh, wait for a while. Please ignore my previous comment. It seems that our CI has some different settings on PR builder and commit builder. I'm digging now. |
Member
Author
|
Ack. |
Member
|
I believe that this will be verified completely by the release manager. If there is any issue, we can revisit this at that time. Thank you, @vrozov . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Upgrade to Apache parent pom version 34
Why are the changes needed?
Version 27 is almost 10 years old.
How was this patch tested?
Running maven build (with and without -Papache-release) profile
Was this patch authored or co-authored using generative AI tooling?
No