-
Notifications
You must be signed in to change notification settings - Fork 1.5k
drivers/sensors: sensor bug fix - part 1 #17824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
dd60fe3 to
6d1bebc
Compare
6d1bebc to
d510572
Compare
jerpelea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add "drivers/sensors:" in front of commit title
|
wait for #17837 and apache/nuttx-apps#3312 |
linguini1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally this could be three separate PRs since the commits seem unrelated.
We have conducted tests on the following platforms
Can you please provide more information about your testing? What did you test on the platforms, how do you know the behaviour is correct, etc.
d510572 to
94e3df0
Compare
|
depend on apache/nuttx-apps#3332 |
ad37cc7 to
a5b1d1b
Compare
done |
a5b1d1b to
ef9b878
Compare
linguini1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please provide more information about your testing? What did you test on the platforms, how do you know the behaviour is correct, etc.
@xiaoxiang781216 as we voted in the mailing list, do not dismiss other reviewers comments please. I am always happy to re review.
Updated,You don't need to xiaoxiang781216, just contact me and I'll see your comments. |
|
This patch depends on apache/nuttx-apps#3332. I'll try modifying build.yaml to see if it can build successfully. |
|
@Otpvondoiats please rebase your patch to the last master which conatain patch to fix the build break. |
| #ifdef CONFIG_USENSOR | ||
| /* Command: SNIOC_SET_INFO | ||
| * Description: Set device information. Only used by user space. | ||
| * Argument: This is the device info pointer. | ||
| */ | ||
|
|
||
| # define SNIOC_SET_INFO _SNIOC(0x009C) | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this considered a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this ioctl is normally used with Android sensor HAL to report the additional sensor info required by Android, since both side is modified, the impact is minimal.
linguini1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Also, is the Unity test an internal tool?
|
@Otpvondoiats please rebase your patch to the last master which fix the ci build break. |
yes,This includes basic functional tests for the sensor framework; |
The logic for obtaining the info and configuring the user buffer have been optimized. Signed-off-by: dongjiuzhu1 <dongjiuzhu1@xiaomi.com> Signed-off-by: likun17 <likun17@xiaomi.com>
Fixes the issue of cross-core IPC being triggered when using O_DIRECT in non-cross-core scenarios. Signed-off-by: likun17 <likun17@xiaomi.com>
of driver information. When the local core is a virtual sensor, attempt to retrieve information from a remote core. Signed-off-by: likun17 <likun17@xiaomi.com>
ef9b878 to
e5d54d9
Compare
Done |
|
I pushed it again, and then a case failed. I built it locally, posted the logs, and then merged it. |
Summary
Impact
Cross-core direct connection and cross-core information retrieval
Testing
uniy test