Update javac package list in APTUtils #8931
Conversation
mbien
added
the
Java
|
@lahodaj could you check if this update is ok? I believe that currently some classes may be loaded using the wrong CL since the list misses some packages. |
mbien
force-pushed
the
update-javac-package-list
branch
from
216db69 to
702d082
Compare
| //keep synchronized with libs.javacapi/manifest.mf and libs.javacimpl/manifest.mf | ||
| //when adding new packages, double-check the quick path in loadClass below: |
There was a problem hiding this comment.
I'm puzzled, I'm not very aware of this part of NetBeans
In
libs.nbjavacapi/manifest.mf
OpenIDE-Module-Hide-Classpath-Packages:
there is a package list that looks like the one here but could be unrelated.
There was a problem hiding this comment.
I think you are right, tracked the file through history and OpenIDE-Module-Hide-Classpath-Packages was modified together with that list.
emilianbold/netbeans-releases@33f67f2
this change is also interesting, although the LambdaMetaFactory.translateClassFile line was commented out again in the CachingArchiveClassLoader
emilianbold/netbeans-releases@2bf2f0d
There was a problem hiding this comment.
is also missing a comma atm! (com.sun.tools.javac.** is there twice)
removed - com.sun.javadoc - com.sun.tools.javadoc - com.sun.tools.hc added - com.sun.tools.doclint - com.sun.tools.javap
mbien
force-pushed
the
update-javac-package-list
branch
from
702d082 to
cc0828e
Compare
2 participants
Saw that list while going through heap dumps and looking through GC roots. Looks important.
Not sure if
org.netbeans.lib.nbjavacneeds to be on it too or only the original javac packages.removed
com.sun.javadoccom.sun.tools.javadoccom.sun.tools.hcadded
com.sun.tools.doclintcom.sun.tools.javap