[MSHARED-1176] Test case for NoSuchFileException while copying symbolic by kwin · Pull Request #110 · apache/maven-shared-utils

kwin · 2022-07-26T17:39:05Z

link with relative non-existing target

kwin · 2022-07-26T17:45:04Z

@slawekjaranowski This depends on #109 being merged first otherwise the build breaks even before executing the unit test.

Update: Done and rebased this PR.

michael-o · 2022-07-26T17:49:53Z

Without testing your PR, here is what I see on FreeBSD (FreeBSD bsd1srv.fritz.box 12.3-STABLE FreeBSD 12.3-STABLE GENERIC amd64) where chmod -h works as expected:

mosipov@bsd1srv:/usr/home/mosipov/var/Projekte/maven-shared-utils (master =)
$ grep chmod /tmp/out
fchmod(188,0100644)                              = 0 (0x0)
chmod("/var/mosipov/Projekte/maven-shared-utils/target/classes/org/apache/maven/shared/utils/annotations.xml",0644) = 0 (0x0)
chmod("/var/mosipov/Projekte/maven-shared-utils/target/classes/org/apache/maven/shared/utils/annotations.xml",0644) = 0 (0x0)
chmod("/var/mosipov/Projekte/maven-shared-utils/target/classes/META-INF/LICENSE",0644) = 0 (0x0)
chmod("/var/mosipov/Projekte/maven-shared-utils/target/classes/META-INF/LICENSE",0644) = 0 (0x0)
chmod("/var/mosipov/Projekte/maven-shared-utils/target/classes/META-INF/DEPENDENCIES",0644) = 0 (0x0)
chmod("/var/mosipov/Projekte/maven-shared-utils/target/classes/META-INF/DEPENDENCIES",0644) = 0 (0x0)
chmod("/var/mosipov/Projekte/maven-shared-utils/target/classes/META-INF/NOTICE",0644) = 0 (0x0)
chmod("/var/mosipov/Projekte/maven-shared-utils/target/classes/META-INF/NOTICE",0644) = 0 (0x0)
chmod("/var/mosipov/Projekte/maven-shared-utils/target/test-classes/directorywalker/directory1/file1.txt",0644) = 0 (0x0)
chmod("/var/mosipov/Projekte/maven-shared-utils/target/test-classes/directorywalker/directory1/file1.txt",0644) = 0 (0x0)
chmod("/var/mosipov/Projekte/maven-shared-utils/target/test-classes/directorywalker/directory2/directory21/file21.txt",0644) = 0 (0x0)
chmod("/var/mosipov/Projekte/maven-shared-utils/target/test-classes/directorywalker/directory2/directory21/file21.txt",0644) = 0 (0x0)
chmod("/var/mosipov/Projekte/maven-shared-utils/target/test-classes/directorywalker/directory2/file2.txt",0644) = 0 (0x0)
chmod("/var/mosipov/Projekte/maven-shared-utils/target/test-classes/directorywalker/directory2/file2.txt",0644) = 0 (0x0)
chmod("/var/mosipov/Projekte/maven-shared-utils/target/test-classes/directorywalker/file.txt",0644) = 0 (0x0)
chmod("/var/mosipov/Projekte/maven-shared-utils/target/test-classes/directorywalker/file.txt",0644) = 0 (0x0)
chmod("/var/mosipov/Projekte/maven-shared-utils/target/test-classes/expand/expand_test.zip",0644) = 0 (0x0)
chmod("/var/mosipov/Projekte/maven-shared-utils/target/test-classes/expand/expand_test.zip",0644) = 0 (0x0)
chmod("/var/mosipov/Projekte/maven-shared-utils/target/test-classes/symlinks/src/targetDir/targetFile.txt",0644) = 0 (0x0)
chmod("/var/mosipov/Projekte/maven-shared-utils/target/test-classes/symlinks/src/targetDir/targetFile.txt",0644) = 0 (0x0)
chmod("/var/mosipov/Projekte/maven-shared-utils/target/test-classes/symlinks/src/fileR.txt",0644) = 0 (0x0)
chmod("/var/mosipov/Projekte/maven-shared-utils/target/test-classes/symlinks/src/fileR.txt",0644) = 0 (0x0)
chmod("/var/mosipov/Projekte/maven-shared-utils/target/test-classes/symlinks/src/symLinkToFileOnTheOutside",0644) ERR#2 'No such file or directory'

and

mosipov@bsd1srv:/usr/home/mosipov/var/Projekte/maven-shared-utils (master =)
$ grep symLinkToFileOnTheOutside /tmp/out
fstatat(AT_FDCWD,"/var/mosipov/Projekte/maven-shared-utils/target/test-classes/symlinks/src/symLinkToFileOnTheOutside",0x7fffdfffc1f0,0x0) ERR#2 'No such file or directory'
fstatat(AT_FDCWD,"/var/mosipov/Projekte/maven-shared-utils/target/test-classes/symlinks/src/symLinkToFileOnTheOutside",{ mode=lrwxr-xr-x ,inode=91832,size=19,blksize=131072 },AT_SYMLINK_NOFOLLOW) = 0 (0x0)
unlink("/var/mosipov/Projekte/maven-shared-utils/target/test-classes/symlinks/src/symLinkToFileOnTheOutside") = 0 (0x0)
fstatat(AT_FDCWD,"/var/mosipov/Projekte/maven-shared-utils/src/test/resources/symlinks/src/symLinkToFileOnTheOutside",{ mode=-rw-r--r-- ,inode=91148,size=839,blksize=4096 },0x0) = 0 (0x0)
fstatat(AT_FDCWD,"/var/mosipov/Projekte/maven-shared-utils/src/test/resources/symlinks/src/symLinkToFileOnTheOutside",{ mode=-rw-r--r-- ,inode=91148,size=839,blksize=4096 },0x0) = 0 (0x0)
fstatat(AT_FDCWD,"/var/mosipov/Projekte/maven-shared-utils/src/test/resources/symlinks/src/symLinkToFileOnTheOutside",{ mode=-rw-r--r-- ,inode=91148,size=839,blksize=4096 },0x0) = 0 (0x0)
fstatat(AT_FDCWD,"/var/mosipov/Projekte/maven-shared-utils/src/test/resources/symlinks/src/symLinkToFileOnTheOutside",{ mode=-rw-r--r-- ,inode=91148,size=839,blksize=4096 },0x0) = 0 (0x0)
fstatat(AT_FDCWD,"/var/mosipov/Projekte/maven-shared-utils/src/test/resources/symlinks/src/symLinkToFileOnTheOutside",{ mode=-rw-r--r-- ,inode=91148,size=839,blksize=4096 },0x0) = 0 (0x0)
fstatat(AT_FDCWD,"/var/mosipov/Projekte/maven-shared-utils/src/test/resources/symlinks/src/symLinkToFileOnTheOutside",{ mode=-rw-r--r-- ,inode=91148,size=839,blksize=4096 },0x0) = 0 (0x0)
fstatat(AT_FDCWD,"/var/mosipov/Projekte/maven-shared-utils/target/test-classes/symlinks/src/symLinkToFileOnTheOutside",0x7fffdfffc460,0x0) ERR#2 'No such file or directory'
fstatat(AT_FDCWD,"/var/mosipov/Projekte/maven-shared-utils/src/test/resources/symlinks/src/symLinkToFileOnTheOutside",{ mode=-rw-r--r-- ,inode=91148,size=839,blksize=4096 },0x0) = 0 (0x0)
fstatat(AT_FDCWD,"/var/mosipov/Projekte/maven-shared-utils/src/test/resources/symlinks/src/symLinkToFileOnTheOutside",{ mode=-rw-r--r-- ,inode=91148,size=839,blksize=4096 },0x0) = 0 (0x0)
fstatat(AT_FDCWD,"/var/mosipov/Projekte/maven-shared-utils/src/test/resources/symlinks/src/symLinkToFileOnTheOutside",{ mode=lrwxr-xr-x ,inode=91158,size=19,blksize=131072 },AT_SYMLINK_NOFOLLOW) = 0 (0x0)
readlink("/var/mosipov/Projekte/maven-shared-utils/src/test/resources/symlinks/src/symLinkToFileOnTheOutside","../onTheOutside.txt",1025) = 19 (0x13)
access("/var/mosipov/Projekte/maven-shared-utils/target/test-classes/symlinks/src/symLinkToFileOnTheOutside",F_OK) ERR#2 'No such file or directory'
symlink("../onTheOutside.txt","/var/mosipov/Projekte/maven-shared-utils/target/test-classes/symlinks/src/symLinkToFileOnTheOutside") = 0 (0x0)
fstatat(AT_FDCWD,"/var/mosipov/Projekte/maven-shared-utils/src/test/resources/symlinks/src/symLinkToFileOnTheOutside",{ mode=-rw-r--r-- ,inode=91148,size=839,blksize=4096 },0x0) = 0 (0x0)
chmod("/var/mosipov/Projekte/maven-shared-utils/target/test-classes/symlinks/src/symLinkToFileOnTheOutside",0644) ERR#2 'No such file or directory'

The symlink or its target does not exist.

kwin · 2022-07-26T17:57:15Z

Yes, exactly. In this case the target does not (yet) exist. The question is how FileUtils.copyFile(...) should behave in that case.

link with relative non-existing target

michael-o · 2022-07-26T18:22:41Z

I'll try to look into this this month.

kwin · 2022-07-26T18:31:44Z

IMHO copy should also not fail in case the source symlink is broken (which it currently does)

michael-o · 2022-07-26T18:56:35Z

IMHO copy should also not fail in case the source symlink is broken (which it currently does)

I agree with that. If source leads to nowhere then dest should do too. Fully valid with POSIX.

source symlink file

kwin · 2022-07-27T06:35:30Z

IMHO copy should also not fail in case the source symlink is broken (which it currently does)

I added another (failing) test case for this scenario in 8ff14a5

michael-o · 2022-07-27T08:03:09Z

From my PoV, it should mimic cp(1).

src/test/java/org/apache/maven/shared/utils/io/FileUtilsTest.java

michael-o · 2023-01-01T20:02:03Z

src/test/java/org/apache/maven/shared/utils/io/FileUtilsTest.java

+            tempFolder.newFolder( "destDirectory" ),
+            "toSymLink"
+        );
+        // this creates a symlink in a new folder pointing to a non-existing relative target "./target.txt"


directory, not folder

michael-o · 2023-01-01T20:02:28Z

src/test/java/org/apache/maven/shared/utils/io/FileUtilsTest.java

+            "toSymLink"
+        );
+        // this creates a symlink in a new folder pointing to a non-existing relative target "./non-existing.txt"
+        FileUtils.copyFile( from.toFile(), to, null, (FileUtils.FilterWrapper[]) null );


directory, not folder

jira-importer · 2025-07-03T08:40:22Z

Resolve #306

kwin marked this pull request as draft July 26, 2022 17:39

[MSHARED-1112] Test case for NoSuchFileException while copying symbolic

da11090

link with relative non-existing target

kwin force-pushed the bugfix/MSHARED-1112-nsfe-on-symlink-copy branch from 94fa38a to da11090 Compare July 26, 2022 18:00

Add test for symbolic link whose target does not even exist for the

8ff14a5

source symlink file

kwin changed the title ~~[MSHARED-1112] Test case for NoSuchFileException while copying symbolic~~ [MSHARED-1176] Test case for NoSuchFileException while copying symbolic Jan 1, 2023

kwin commented Jan 1, 2023

View reviewed changes

src/test/java/org/apache/maven/shared/utils/io/FileUtilsTest.java Outdated Show resolved Hide resolved

Update src/test/java/org/apache/maven/shared/utils/io/FileUtilsTest.java

ab4ca12

michael-o requested changes Jan 1, 2023

View reviewed changes

jira-importer mentioned this pull request Aug 3, 2022

[MSHARED-899] Upgrade commons-io to 2.7 #293

Closed

slachiewicz added the bug Something isn't working label Feb 1, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MSHARED-1176] Test case for NoSuchFileException while copying symbolic#110

[MSHARED-1176] Test case for NoSuchFileException while copying symbolic#110
kwin wants to merge 3 commits intoapache:masterfrom
kwin:bugfix/MSHARED-1112-nsfe-on-symlink-copy

kwin commented Jul 26, 2022

Uh oh!

kwin commented Jul 26, 2022 •

edited

Loading

Uh oh!

michael-o commented Jul 26, 2022 •

edited

Loading

Uh oh!

kwin commented Jul 26, 2022

Uh oh!

michael-o commented Jul 26, 2022

Uh oh!

kwin commented Jul 26, 2022

Uh oh!

michael-o commented Jul 26, 2022 •

edited

Loading

Uh oh!

kwin commented Jul 27, 2022

Uh oh!

michael-o commented Jul 27, 2022

Uh oh!

Uh oh!

michael-o Jan 1, 2023

Uh oh!

michael-o Jan 1, 2023

Uh oh!

jira-importer commented Jul 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

kwin commented Jul 26, 2022

Uh oh!

kwin commented Jul 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michael-o commented Jul 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kwin commented Jul 26, 2022

Uh oh!

michael-o commented Jul 26, 2022

Uh oh!

kwin commented Jul 26, 2022

Uh oh!

michael-o commented Jul 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kwin commented Jul 27, 2022

Uh oh!

michael-o commented Jul 27, 2022

Uh oh!

Uh oh!

michael-o Jan 1, 2023

Choose a reason for hiding this comment

Uh oh!

michael-o Jan 1, 2023

Choose a reason for hiding this comment

Uh oh!

jira-importer commented Jul 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kwin commented Jul 26, 2022 •

edited

Loading

michael-o commented Jul 26, 2022 •

edited

Loading

michael-o commented Jul 26, 2022 •

edited

Loading