Skip to content

Fixing several spotbugs warnings #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MateusJunior7 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixing several spotbugs warnings #1030

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e82276
Fix UWF_NULL_FIELD: initialize mojoDependencies list
MateusJunior7 Nov 16, 2025
c3e2a8e
Check mkdirs() return value when creating outputDirectory
MateusJunior7 Nov 16, 2025
c44d390
Narrow exception type in generateIndex(): replace catch(Exception) wi…
MateusJunior7 Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions ...n-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import java.nio.file.Files;
import java.nio.file.Path;
import java.util.*;
import java.util.ArrayList;
import java.util.stream.Collectors;
import java.util.stream.Stream;

Expand Down Expand Up @@ -196,7 +197,7 @@ public class DescriptorGeneratorMojo extends AbstractGeneratorMojo {
* @since 3.5
*/
@Parameter
private List<String> mojoDependencies = null;
private final List<String> mojoDependencies = new ArrayList<>();
Copy link
Member

@slawekjaranowski slawekjaranowski Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can not be a final ... Maven need a possibility to set this filed during plugin configuration


/**
* Creates links to existing external javadoc-generated documentation.
Expand Down Expand Up @@ -372,7 +373,12 @@ public void generate() throws MojoExecutionException {
mojoScanner.populatePluginDescriptor(request);
request.setPluginDescriptor(extendPluginDescriptor(request));

outputDirectory.mkdirs();
if (!outputDirectory.exists()) {
Copy link

@ascopes ascopes Dec 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would https://docs.oracle.com/javase/8/docs/api/java/nio/file/Files.html#createDirectories-java.nio.file.Path-java.nio.file.attribute.FileAttribute be more sensible to use here? It handles the case that the directory already exists, throwing appropriate exceptions for any other kinds of issue, so will likely be more descriptive than handling this manually. There is use of java.nio.file.Path further down this file as well, so the NIO API appears to already be in use.

I believe the whole snippet here would just become:

Files.createDirectories(outputDirectory.toPath());

In Maven 4, I believe the outputDirectories parameter could itself be replaced with a java.nio.file.Path, since the latest version of Sisu supports both the URI and nio Path APIs out of the box... that'd remove the need to convert back from the old APIs at all.

https://github.com/eclipse-sisu/sisu-project/blob/e86e5005ff03b57aab8c7eb7f54f41e85914e2dd/org.eclipse.sisu.plexus/src/main/java/org/codehaus/plexus/component/configurator/converters/basic/PathConverter.java#L33

if (!outputDirectory.mkdirs()) {
throw new MojoExecutionException(
"Could not create output directory: " + outputDirectory.getAbsolutePath());
}
}

PluginDescriptorFilesGenerator pluginDescriptorGenerator = new PluginDescriptorFilesGenerator();
pluginDescriptorGenerator.execute(outputDirectory, request);
Expand Down Expand Up @@ -459,7 +465,7 @@ public AnnotationVisitor visitAnnotation(String descriptor, boolean visible) {
w.write(content);
}
}
} catch (Exception e) {
} catch (IOException e) {
throw new GeneratorException("Unable to generate index for v4 beans", e);
}
}
Expand Down