Check mkdirs() return value when creating output directory in DescriptorGeneratorMojo#1029
Closed
MateusJunior7 wants to merge 2 commits intoapache:masterfrom
Closed
Check mkdirs() return value when creating output directory in DescriptorGeneratorMojo#1029MateusJunior7 wants to merge 2 commits intoapache:masterfrom
MateusJunior7 wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
|
part of #1030 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a RV_RETURN_VALUE_IGNORED_BAD_PRACTICE warning reported by SpotBugs in
org.apache.maven.plugin.plugin.DescriptorGeneratorMojo.generate().
The call to java.io.File.mkdirs() previously ignored its boolean return value.
The code now:
Checks whether the output directory already exists.
Calls mkdirs() only when necessary.
Throws a MojoExecutionException when directory creation fails, instead of silently ignoring the error.
After this change, the RV warning no longer appears in the SpotBugs report for this class.