Skip to content

Avoid referring to PluginBuilderAttribute.class in PluginProcessor #4041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cushon wants to merge 1 commit into
base: 2.x
Choose a base branch
from
+6 −2
Open

Avoid referring to PluginBuilderAttribute.class in PluginProcessor #4041

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...src/main/java/org/apache/logging/log4j/core/config/plugins/processor/PluginProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@
import javax.tools.StandardLocation;
import org.apache.logging.log4j.core.config.plugins.Plugin;
import org.apache.logging.log4j.core.config.plugins.PluginAliases;
import org.apache.logging.log4j.core.config.plugins.PluginBuilderAttribute;
import org.apache.logging.log4j.util.Strings;

/**
Expand Down Expand Up @@ -84,9 +83,13 @@ public SourceVersion getSupportedSourceVersion() {
return SourceVersion.latest();
}

private static final String PLUGIN_BUILDER_ATTRIBUTE_ANNOTATION =
"org.apache.logging.log4j.core.config.plugins.PluginBuilderAttribute";

@Override
public boolean process(final Set<? extends TypeElement> annotations, final RoundEnvironment roundEnv) {
final Messager messager = processingEnv.getMessager();
final Elements elementUtils = processingEnv.getElementUtils();
// Process the elements for this round
if (!annotations.isEmpty()) {
final Set<? extends Element> elements = roundEnv.getElementsAnnotatedWith(Plugin.class);
Expand All @@ -95,7 +98,8 @@ public boolean process(final Set<? extends TypeElement> annotations, final Round

// process plugin builder Attributes
final Set<? extends Element> pluginAttributeBuilderElements =
roundEnv.getElementsAnnotatedWith(PluginBuilderAttribute.class);
roundEnv.getElementsAnnotatedWith(
elementUtils.getTypeElement(PLUGIN_BUILDER_ATTRIBUTE_ANNOTATION));
processBuilderAttribute(pluginAttributeBuilderElements);
processedElements.addAll(pluginAttributeBuilderElements);
}
Expand Down