feat(datafusion): Support CREATE EXTERNAL TABLE with catalog #2022
+532
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @CTTY for this pr, just finished first round of review, it looks great!
| let table_ident = TableIdent::new(namespace.clone(), name.clone()); | ||
|
|
||
| // Check if table exists before attempting to load | ||
| if !catalog |
Contributor
There was a problem hiding this comment.
When datafusion calls this method to create a table, it already has deregistered table. But since datafusion allows no-iceberg catalog to register iceberg table, this check may still miss match. I think we should do is that:
if catalog.table.exists(...) {
return Error::new(ErrorKind::DataInvalid, "Table already exists in iceberg catalog ..., this maybe a misconfig datafusion catalog provider vs iceberg catalog.");
}
|
|
||
| # Create external table with bare name (uses "default" namespace) | ||
| statement ok | ||
| CREATE EXTERNAL TABLE ns_table STORED AS ICEBERG LOCATION '' |
Contributor
There was a problem hiding this comment.
Can we have a test for partitioned table?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
CREATE EXTERNAL TABLEbacked by a Catalog with DataFusion #2021What changes are included in this PR?
CREATE EXTERNAL TABLEwith catalog so the table is writableAre these changes tested?
Added some uts and sqllogictests