fix: allow v2 to v3 table upgrades with existing snapshots #2010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make row lineage fields `first-row-i` and `added-rows` optional in SnapshotV3 to support upgrading tables of older versions with pre-existing snapshots. According to the Iceberg spec, existing snapshots should remain unchanged during upgrades from to v3. Additionally, this also fixes the initialization of the next-row-id during upgrades, as defined in the spec: https://iceberg.apache.org/spec/#row-lineage-for-upgraded-tables.
Contributor
Author
|
Thanks @CTTY! @liurenjie1024 @kevinjqliu could you please sign off on this PR if it looks good to you? Thanks. |
liurenjie1024
approved these changes
Jan 16, 2026
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @aditya-subrahmanyan for this fix!
Contributor
Author
|
Thanks for the review @liurenjie1024, please merge the PR when you get chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Make row lineage fields
first-row-idandadded-rowsoptional in SnapshotV3 to support upgrading tables of older versions with pre-existing snapshots. According to the Iceberg spec, existing snapshots should remain unchanged during upgrades from to v3.Additionally, this also fixes the initialization of the next-row-id during upgrades, as defined in the spec:
https://iceberg.apache.org/spec/#row-lineage-for-upgraded-tables.
Are these changes tested?
Added tests to validate v2 to v3 upgrade for table metadata, as described in the issue, and confirm that row lineage information is preserved/generated correctly.