-
Notifications
You must be signed in to change notification settings - Fork 141
Initial support for Hive Catalog. #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ceberg-go into hive_catalog_support
|
The current implementation of |
zeroshade
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long delay here, it's been a very busy couple weeks. Here's my first pass, more comments to come later tonight/tomorrow
| ) | ||
|
|
||
| type HiveClient interface { | ||
| Close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not using an io.Closer where the Close method returns error?
| "github.com/beltran/gohive/hive_metastore" | ||
| ) | ||
|
|
||
| type HiveClient interface { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any particular reason to export this? Is the intent that users should be able to provide their own HiveClient if they want?
| client *gohive.HiveMetastoreClient | ||
| } | ||
|
|
||
| func NewHiveClient(uri string, opts *HiveOptions) (HiveClient, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we expect users to actually be using this directly as opposed to just using NewCatalog?
| // Determine authentication mode | ||
| auth := "NOSASL" | ||
| if opts != nil && opts.KerberosAuth { | ||
| auth = "KERBEROS" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm reading gohive correctly, this requires the kerberos tag to build correctly, right? Can we instead use one of the pure go implementations that don't rely on cgo? Like gokrb etc.
|
|
||
| func (c *thriftClient) Close() { | ||
| if c.client != nil { | ||
| c.client.Close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we set c.client = nil after we close?
| } | ||
|
|
||
| type thriftClient struct { | ||
| client *gohive.HiveMetastoreClient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the methods here just forward to client, should we just embed the client rather than have it be a member?
closes: #616