refactor: rename columnar storage #1626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
您好： 邮件已收到！
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the naming of the storage component to "columnar_storage" for clarity and specificity. Key changes include:
- Updating dependency names in Cargo.toml files.
- Renaming the package name in src/columnar_storage/Cargo.toml.
- Adjusting import paths in the benchmarks to reference the new name.
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/metric_engine/Cargo.toml | Replaced dependency "horaedb_storage" with "columnar_storage". |
| src/columnar_storage/Cargo.toml | Updated the package name from "storage" to "columnar_storage". |
| src/benchmarks/src/encoding_bench.rs | Modified import to reference "columnar_storage" instead of "horaedb_storage". |
| src/benchmarks/Cargo.toml | Changed dependency from "horaedb_storage" to "columnar_storage". |
| Cargo.toml | Updated workspace members and dependency paths to reflect the new name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Currently the name
storageis too general, columnar storage is more precise.Detailed Changes
Test Plan
No need