Load the root gradle.properties only for properties not already set in buildSrc

[jamesfredley]

This matches the code from grails-core: https://github.com/apache/grails-core/blob/7.0.x/buildSrc/build.gradle#L24-L28

[Copilot]

Pull Request Overview

This PR updates the buildSrc Gradle script to pull the Grails version from the root gradle.properties file instead of hardcoding via VersionInfo.

• Loads gradle.properties into project.ext.gradleProperties
• Switches the grails-gradle-bom platform dependency to interpolate gradleProperties.grailsVersion

Comments suppressed due to low confidence (1)

grails-forge-core/src/main/java/org/grails/forge/feature/build/gradle/templates/buildSrcBuildGradle.rocker.raw:35

• Gradle automatically loads gradle.properties into project properties, so you can drop the manual file read block and use project.property('grailsVersion') directly for cleaner and more idiomatic code.

file('../gradle.properties').withInputStream {

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[jdaugherty]

There are downsides to importing properties... for us it did not matter, but for end grails applications it means they can't set properties via environment variables. Shouldn't projects make this decision theirselves?

[jamesfredley]

@jdaugherty I updated this to a goldilocks setup which supports buildSrc/gradle.properties, environment variables and /gradle.properties with /gradle.properties only applied when the variable does not exist in the others.

Having a single location defining versions is a HUGE win and this enables it for users that want to use buildSrc. I also think this should be the default in Gradle, but that is another conversation.

[jdaugherty]

@jdaugherty I updated this to a goldilocks setup which supports buildSrc/gradle.properties, environment variables and /gradle.properties with /gradle.properties only applied when the variable does not exist in the others.

Having a single location defining versions is a HUGE win and this enables it for users that want to use buildSrc. I also think this should be the default in Gradle, but that is another conversation.

I had no idea the environment variables work for properties in buildSrc. That even makes this problem even more confusing because the gradle.properties do not. It seems gradle/gradle#1001 indicated that buildSrc should be treated like a child build and there is also a separate gradle ticket covering this scenario for child builds: gradle/gradle#2534 So I guess this is still an upstream todo?

Your change appears to work for both variables & gradle.properties, so I'm ok with this.

[jdaugherty]

Let's at least reference the upstream gradle issue so people know why we made this change?