-
-
Notifications
You must be signed in to change notification settings - Fork 970
Update Java, Gradle, and Groovy versions #15355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumped the Groovy version to 3.0.25 in grails-data-graphql, grails-data-neo4j, and grails-forge modules to ensure consistency and benefit from the latest bug fixes and improvements.
The Rocker template for gradle-wrapper.properties was still using Gradle 8.14.3, causing CreateControllerCommandSpec to timeout while downloading the older Gradle distribution.
Added comments to all 9 locations where Gradle 8.14.4 is defined, referencing the other locations that need to be updated together to help maintainers keep versions in sync.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request updates Java, Gradle, and Groovy versions across the Grails codebase and adds cross-reference comments to help maintain version consistency across multiple configuration files.
Changes:
- Update Java version from 17.0.17 to 17.0.18 across .sdkmanrc files, Dockerfile, and CI workflows
- Update Gradle from 8.14.3 to 8.14.4 in all gradle-wrapper.properties files and gradleToolingApiVersion
- Update Groovy to version 3.0.25 in multiple module gradle.properties files
- Add cross-reference comments to all 9 Gradle version locations for easier maintenance
- Update CI test matrices to test with Java 17, 25 (and 21 in some cases)
- Update Spring Boot to 3.5.10 in test example
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| grails-test-examples/gsp-spring-boot/script/.sdkmanrc | Updates Java to 17.0.18 and Spring Boot to 3.5.10 for test example |
| grails-profiles/profile/skeleton/gradle/wrapper/gradle-wrapper.properties | Updates Gradle wrapper to 8.14.4 and adds cross-reference comment |
| grails-profiles/base/skeleton/gradle/wrapper/gradle-wrapper.properties | Updates Gradle wrapper to 8.14.4 and adds cross-reference comment |
| grails-gradle/gradle/wrapper/gradle-wrapper.properties | Updates Gradle wrapper to 8.14.4 and adds cross-reference comment |
| grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/build/gradle/templates/gradleWrapperProperties.rocker.raw | Updates Gradle template to 8.14.4 and adds cross-reference comment |
| grails-forge/gradle/wrapper/gradle-wrapper.properties | Updates Gradle wrapper to 8.14.4 and adds cross-reference comment |
| grails-forge/gradle.properties | Updates Groovy version from 3.0.24 to 3.0.25 |
| grails-data-neo4j/gradle.properties | Updates Groovy version from 3.0.20 to 3.0.25 |
| grails-data-graphql/gradle.properties | Updates Groovy version from 3.0.11 to 3.0.25 |
| gradle/wrapper/gradle-wrapper.properties | Updates Gradle wrapper to 8.14.4 and adds cross-reference comment |
| gradle.properties | Updates Gradle Tooling API version to 8.14.4 and adds cross-reference comment |
| etc/bin/Dockerfile | Updates Java base image to 17.0.18 and adds cross-reference comment |
| build-logic/gradle/wrapper/gradle-wrapper.properties | Updates Gradle wrapper to 8.14.4 and adds cross-reference comment |
| .sdkmanrc | Updates Java to 17.0.18, Gradle to 8.14.4, and adds cross-reference comments |
| .github/workflows/release.yml | Updates Java version to 17.0.18 with cross-reference comment |
| .github/workflows/gradle.yml | Updates CI test matrices replacing Java 21 with Java 25 in some jobs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The PR changes in .github/workflows/gradle.yml replace Java 21 with Java 25 in the buildGradle, mongodbFunctional, and hibernate5Functional job matrices, rather than adding Java 25 alongside Java 21. This matches your observation that the description should be updated to clarify the removal of Java 21 testing in those matrices, or Java 21 should be retained if the change was unintentional. |
Summary
Test plan