Skip to content

test: stabilize get-webpage cases in TestHiveStore #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jack-LuoHongyi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test: stabilize get-webpage cases in TestHiveStore #303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions gora-hive/src/test/java/org/apache/gora/hive/store/TestHiveStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,14 @@
package org.apache.gora.hive.store;

import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;

import java.nio.ByteBuffer;
import java.nio.charset.Charset;
import java.util.ArrayList;
import java.util.Set;
import org.apache.avro.util.Utf8;
import org.apache.gora.examples.WebPageDataCreator;
import org.apache.gora.examples.generated.Employee;
import org.apache.gora.examples.generated.Metadata;
import org.apache.gora.examples.generated.WebPage;
Expand All @@ -34,6 +36,7 @@
import org.apache.gora.store.DataStoreTestUtil;
import org.apache.gora.util.GoraException;
import org.apache.gora.util.StringUtils;
import org.apache.metamodel.query.parser.QueryParserException;
import org.junit.Ignore;
import org.junit.Test;

Expand All @@ -56,6 +59,25 @@ public void assertSchemaExists(String schemaName) throws Exception {
assertTrue(employeeStore.schemaExists());
}

private void awaitWebPageSchema(String key) throws Exception {
for (int attempt = 0; attempt < 100; attempt++) {
webPageStore.flush();
if (!webPageStore.schemaExists()) {
Thread.sleep(100L);
continue;
}
if (key == null) return;
try {
webPageStore.get(key, new String[] {"url"});
return;
} catch (QueryParserException e) {
webPageStore.close();
webPageStore = testDriver.createDataStore(String.class, WebPage.class);
}
}
fail("Hive web page schema or record was not visible");
}

@Override
public void assertPut(Employee employee) throws GoraException {
employeeStore.put(employee.getSsn().toString(), employee);
Expand Down Expand Up @@ -122,6 +144,32 @@ public void testGetNested() throws Exception {
DataStoreTestUtil.assertEqualWebPageObjects(webpage, after.getWebpage());
}

private void testGetWebPage(String[] fields) throws Exception {
WebPageDataCreator.createWebPageData(webPageStore);
awaitWebPageSchema(WebPageDataCreator.URLS[0]);
for (int i = 0; i < WebPageDataCreator.URLS.length; i++) {
WebPage page = webPageStore.get(WebPageDataCreator.URLS[i], fields);
DataStoreTestUtil.assertWebPage(page, i);
}
}

@Override
public void testGetWebPage() throws Exception {
testGetWebPage(((HiveStore<String, WebPage>) webPageStore).getFields());
}

@Override
public void testGetWebPageDefaultFields() throws Exception {
testGetWebPage(null);
}

@Override
public void testGetPartitions() throws Exception {
WebPageDataCreator.createWebPageData(webPageStore);
awaitWebPageSchema(WebPageDataCreator.URLS[0]);
DataStoreTestUtil.testGetPartitions(webPageStore, webPageStore.newQuery());
}

@Ignore("Hive test server doesn't support deleting and updating entries")
@Override
public void testExists() throws Exception {
Expand Down
Loading