chore: rename BucketView to BucketRecords#370
Merged
luoyuxia merged 1 commit intoapache:mainfrom Feb 24, 2026
Merged
Conversation
Contributor
Author
|
@luoyuxia PTAL 🙏 |
fresh-borzoni
commented
Feb 23, 2026
| for (size_t b = 0; b < scan_records.BucketCount(); ++b) { | ||
| auto bucket_view = scan_records.BucketAt(b); | ||
| if (!bucket_view.Empty()) { | ||
| auto bkt_records = scan_records.BucketAt(b); |
Contributor
Author
There was a problem hiding this comment.
otherwise shadowed
fresh-borzoni
force-pushed
the
chore-fix-bucket-view-name
branch
from
c435ea7 to
61e42ba
Compare
There was a problem hiding this comment.
Pull request overview
Renames the C++ per-bucket scan result wrapper type from BucketView to BucketRecords to better reflect its semantics, aligning with the API discussion in #351.
Changes:
- Renamed C++ API return types
ScanRecords::Records()/ScanRecords::BucketAt()fromBucketViewtoBucketRecords. - Updated C++ header/source, tests, and Rust-side comments to use the new name.
- Updated C++ API reference docs to reflect the new type name and wording.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| website/docs/user-guide/cpp/api-reference.md | Updates public C++ docs to reference BucketRecords instead of BucketView. |
| bindings/cpp/test/test_log_table.cpp | Updates test comments/variables to use BucketRecords naming. |
| bindings/cpp/src/table.cpp | Renames implementations and exception messages to BucketRecords. |
| bindings/cpp/src/lib.rs | Updates Rust-side comment to reflect the renamed C++ type. |
| bindings/cpp/include/fluss.hpp | Renames the public C++ type and updates ScanRecords method signatures accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
luoyuxia
approved these changes
Feb 24, 2026
Contributor
luoyuxia
left a comment
luoyuxia
left a comment
There was a problem hiding this comment.
@fresh-borzoni Thanks. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as discussed in #351 (comment)