FINERACT-1659: Prevent duplicate savings interest posting in same period #5357
+124
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the duplicate interest posting issue reported in FINERACT-1659, where the Post Interest job could post interest multiple times for the same savings account within the same posting period.
What changed
SavingsSchedularInterestPosterto skip accounts where interest has already been posted for the current period, by comparinginterestPostedTillDatewith the current business date.SERIALIZABLEto prevent duplicate postings caused by race conditions during parallel scheduler runs.Tests
Added two integration tests to validate the behavior:
testPostInterestPreventsDuplicateOnSameDayEnsures running the job twice on the same day results in only one interest posting.
testPostInterestSkipsCurrentPeriodButAllowsNewPeriodEnsures the job skips reposting within the current period, while still allowing postings in a new period.
Expected outcome