Skip to content

DRILL-8511: Overflow appeared when the batch reached rows limit #2943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rymarm wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

DRILL-8511: Overflow appeared when the batch reached rows limit #2943

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
092c226
DRILL-8511: Overflow appeared when the batch reached rows limit
rymarm Sep 18, 2024
dfdc913
Resolve bug tests caught
rymarm Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/writer/BitColumnWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ protected int prepareWrite() {
// Please be thoughtful when changing the code.

final int writeIndex = vectorIndex.vectorIndex();
prepareWrite(writeIndex);
prepareWrite(writeIndex - 1);

// Track the last write location for zero-fill use next time around.

Expand All @@ -84,7 +84,7 @@ private void prepareWrite(int writeIndex) {

@Override
public void setValueCount(int valueCount) {
prepareWrite(valueCount);
prepareWrite(valueCount - 1);
mutator.setValueCount(valueCount);
}

Expand Down