Skip to content

Conversation

@Reranko05
Copy link

This PR adds a unit test reproducing IO-771.

FilenameUtils.getFullPathNoEndSeparator behaves inconsistently on
Windows vs POSIX systems when resolving directory paths.

This PR intentionally adds a failing test only; I’m happy to follow up
with an implementation once the expected cross-platform behavior is agreed upon.

@Reranko05 Reranko05 marked this pull request as draft January 18, 2026 15:23
@Reranko05
Copy link
Author

This test exposes IO-771, but expected cross-platform behavior is unclear.
Converting to draft to avoid blocking CI.
Happy to update the test or add a fix once the desired behavior is agreed.

Copy link
Member

@garydgregory garydgregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Reranko05
This test mixes testing 2 APIs in a confusing manner.
Instead, use the newly added FilenameUtilsTest.testGetFullPathNoEndSeparator_IO_771() and base you fix on that.
Thank you.

@Reranko05 Reranko05 closed this Jan 18, 2026
@Reranko05 Reranko05 force-pushed the fix-IO-771-filenameutils branch from a399a82 to 7246479 Compare January 18, 2026 15:49
@garydgregory
Copy link
Member

So you're not going to update this PR with a fix?

@Reranko05
Copy link
Author

Apologies for the confusion, I closed this PR to avoid blocking CI after realizing the test already existed upstream.
I’ve now submitted a separate PR with the actual fix, based on FilenameUtilsTest.testGetFullPathNoEndSeparator_IO_771, as you suggested.
Happy to continue the discussion there.

FIX PR : #824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants