Skip to content

Conversation

@Reranko05
Copy link

This PR adds a unit test that reproduces IO-639.

ReversedLinesFileReader does not return an empty first line when a file
starts with a line separator (for example, a newline-only file). The
added test demonstrates the current behavior and documents the expected
result.

A fix appears to require deeper refactoring of ReversedLinesFileReader,
so this PR is limited to test coverage only.

Copy link
Member

@garydgregory garydgregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Reranko05
-1: This PR fails the build and this class already contains the disabled test testEmptyFirstLine(int). An additional test would only be needed if a fix was included that required coverage not already provided.

@Reranko05
Copy link
Author

Thanks for clarification, Gary.
Understood, I missed that testEmptyFirstLine(int) already exists in a disabled state.
Since this PR does not include a fix and the coverage already exists, I agree that this additional test case is unnecessary.
I will close the PR accordingly. Thanks for the review and guidance.

@Reranko05 Reranko05 closed this Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants