fix: clean magic value, and update if-else to switch

[cheng102e]

Description

This PR...

clean magic value, and update if-else to switch

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

• In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
• Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
• Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
• Be sure to read the CloudStack Coding Conventions.
  Apache CloudStack is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@cloudstack.apache.org (https://cloudstack.apache.org/mailing-lists.html)
  Slack: https://apachecloudstack.slack.com/

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.60%. Comparing base (128dbe2) to head (d29fda7).
⚠️ Report is 20 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...-proxy/rdpconsole/src/main/java/common/Client.java	0.00%	19 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.22    #8848   +/-   ##
=========================================
  Coverage     17.60%   17.60%           
- Complexity    15615    15616    +1     
=========================================
  Files          5911     5911           
  Lines        529966   529967    +1     
  Branches      64747    64748    +1     
=========================================
+ Hits          93285    93289    +4     
+ Misses       426180   426178    -2     
+ Partials      10501    10500    -1     

Flag	Coverage Δ
uitests	3.60% <ø> (ø)
unittests	18.67% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9099

[DaanHoogland]

clgtm

[DaanHoogland]

@blueorangutan test alma9 kvm-alma9

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

[weizhouapache]

suggestion:

use EnumUtils.getEnumIgnoreCase with a default value

[blueorangutan]

[SF] Trillian test result (tid-9656)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 53600 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8848-t9656-kvm-alma9.zip
Smoke tests completed. 127 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_enableHumanReadableLogs	Error	0.16	test_human_readable_logs.py
test_03_secured_to_nonsecured_vm_migration	Error	155.35	test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration	Error	274.39	test_vm_life_cycle.py

[DaanHoogland]

suggestion:

use EnumUtils.getEnumIgnoreCase with a default value

@cheng102e , will you replace the switch statement?

[sureshanaparti]

i think, no need of this string definitions, try with string to enum constant conversion?

[sureshanaparti]

@blueorangutan package

[Copilot]

Pull Request Overview

This PR refactors the protocol selection logic for the RDP console client by replacing magic-string comparisons with static constant values and updating an if-else chain to a switch statement.

• Removed magic values by introducing constants for protocol names.
• Replaced an if-else chain with a switch statement to improve clarity and maintainability.

[DaanHoogland]

@cheng102e , will you still be looking at this (and answer #8848 (comment)) ?

[sureshanaparti]

minor nit, current code lgtm

[sureshanaparti]

@blueorangutan package

[RosiKyu]

@blueorangutan package

[blueorangutan]

@rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15448

[RosiKyu]

@blueorangutan test

[blueorangutan]

@rosi-shapeblue a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-14661)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 57653 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8848-t14661-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[rajujith]

@cheng102e Since this is for the 4.22.1 release, could you retarget the PR to the 4.22 branch?

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16552

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16561

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-15306)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 49413 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8848-t15306-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[boring-cyborg]

Awesome work, congrats on your first merged pull request!