-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix KvmSshToAgentEnabled setting description and make it dynamic #12533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix KvmSshToAgentEnabled setting description and make it dynamic #12533
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #12533 +/- ##
=============================================
- Coverage 17.85% 3.57% -14.28%
=============================================
Files 5930 448 -5482
Lines 531409 37908 -493501
Branches 64963 7008 -57955
=============================================
- Hits 94869 1357 -93512
+ Misses 425914 36385 -389529
+ Partials 10626 166 -10460
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 16570 |
shwstppr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nvazquez should we target this for 4.22.1 or 4.20.3 as the config is present there?
Description
This PR makes the setting
kvm.ssh.to.agentdynamic, and updates its description as pointed out on the issue #12529.The setting has been introduced with the wrong description on the PR: #3239
Fixes: #12529
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?