Apply reordered ACL list to VR router

[sudo87]

Description

This PR address #9398

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

Before reordering:

After reordering:

Screen.Recording.2026-01-27.at.3.44.40.PM.mov

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.60%. Comparing base (b1f870a) to head (df3afab).
⚠️ Report is 44 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...cloud/network/element/VpcVirtualRouterElement.java	0.00%	9 Missing ⚠️
...a/com/cloud/network/vpc/NetworkACLServiceImpl.java	0.00%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.22   #12525   +/-   ##
=========================================
  Coverage     17.59%   17.60%           
- Complexity    15611    15613    +2     
=========================================
  Files          5910     5911    +1     
  Lines        529890   529972   +82     
  Branches      64737    64750   +13     
=========================================
+ Hits          93259    93278   +19     
- Misses       426135   426194   +59     
- Partials      10496    10500    +4     

Flag	Coverage Δ
uitests	3.60% <ø> (-0.01%)	⬇️
unittests	18.67% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sudo87]

@blueorangutan package

[blueorangutan]

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[weizhouapache]

code lgtm

@sudo87
is there a unit test for it ? if yes, can you update it ?

[weizhouapache]

@sudo87
can you add screenshots of your testing

• current UI and iptables rules
• new UI and iptables rules after reordering

[sudo87]

Thank you @weizhouapache for the review and useful suggestion. I’ve added screenshots showing the UI behavior and iptables rules before and after reordering the ACL.

There are currently no unit test covering reordering logic.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16557

[sudo87]

@blueorangutan test

[blueorangutan]

@sudo87 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[weizhouapache]

looks good, thanks @sudo87 for the update!

[Pearl1594]

Tested - works as expected, on re-ordering the ACLs the iptable rules on the VPR VR gets reordered.

[blueorangutan]

[SF] Trillian test result (tid-15307)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53718 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12525-t15307-kvm-ol8.zip
Smoke tests completed. 148 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_create_template	Error	898.24	test_templates.py

[shwstppr]

Mergiing based on tests and reviews