Improve logs for VM migrations

[nvazquez]

Description

This PR adds more comprehensive logs to the VM migration flow

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 10.81081% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.59%. Comparing base (55ab7c5) to head (28791e2).

Files with missing lines	Patch %	Lines
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java	0.00%	21 Missing ⚠️
...resource/wrapper/LibvirtMigrateCommandWrapper.java	37.50%	5 Missing ⚠️
...pper/LibvirtPrepareForMigrationCommandWrapper.java	20.00%	4 Missing ⚠️
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #12332      +/-   ##
============================================
- Coverage     17.59%   17.59%   -0.01%     
  Complexity    15595    15595              
============================================
  Files          5910     5910              
  Lines        529606   529634      +28     
  Branches      64705    64707       +2     
============================================
+ Hits          93178    93182       +4     
- Misses       425940   425964      +24     
  Partials      10488    10488              

Flag	Coverage Δ
uitests	3.57% <ø> (ø)
unittests	18.66% <10.81%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16147

[DaanHoogland]

clgtm, just some nitpicking

[DaanHoogland]

i don’t think this condition is needed (with log4j2 anymore)

Suggested change

	if (logger.isDebugEnabled()) {
	logger.debug("Configured DPDK interface for VM {}", vm.getName());
	}
	logger.debug("Configured DPDK interface for VM {}", vm.getName());

[DaanHoogland]

Suggested change

	if (logger.isInfoEnabled()) {
	logger.info("Starting migration of VM {} from host {} to host {} ", vm.getInstanceName(), srcHostId, dest.getHost().getId());
	}
	logger.info("Starting migration of VM {} from host {} to host {} ", vm.getInstanceName(), srcHostId, dest.getHost().getId());