Fix: Condition for aborting migration, resume paused VMs on destination #12331
+17
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@blueorangutan package |
|
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #12331 +/- ##
=========================================
Coverage 16.23% 16.23%
- Complexity 13377 13378 +1
=========================================
Files 5657 5657
Lines 498865 498878 +13
Branches 60545 60546 +1
=========================================
+ Hits 80991 81011 +20
+ Misses 408843 408834 -9
- Partials 9031 9033 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16145 |
Comment on lines
+317
to
+331
| DomainState dmState = null; | ||
| try { | ||
| dmState = destDomain.getInfo().state; | ||
| } catch (final LibvirtException e) { | ||
| logger.info("Failed to get domain state for VM: " + vmName + " due to: " + e.getMessage()); | ||
| } | ||
|
|
||
| if (dmState == DomainState.VIR_DOMAIN_PAUSED) { | ||
| logger.info("Resuming VM " + vmName + " on destination after migration"); | ||
| try { | ||
| destDomain.resume(); | ||
| } catch (final Exception e) { | ||
| logger.error("Failed to resume vm " + vmName + " on destination after migration due to : " + e.getMessage()); | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the following:
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?