Skip to content

Conversation

@wolfchkov
Copy link

@wolfchkov wolfchkov commented Dec 19, 2025

Description

Fixes an issue in NsxResource.executeRequest where Network.Service comparison failed when DeleteNsxNatRuleCommand was executed in a different process. Due to serialization/deserialization, the deserialized Network.Service instance was not equal to the static instances Network.Service.StaticNat and Network.Service.PortForwarding, causing the comparison to always return false.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Rewrite unit test to check this bug.

How did you try to break this feature and the system with this change?

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, tnx @wolfchkov

@codecov
Copy link

codecov bot commented Dec 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.58%. Comparing base (5bf869c) to head (57129ff).

❗ There is a different number of reports uploaded between BASE (5bf869c) and HEAD (57129ff). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf869c) HEAD (57129ff)
unittests 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##               main   #12311       +/-   ##
=============================================
- Coverage     17.51%    3.58%   -13.93%     
=============================================
  Files          5914      445     -5469     
  Lines        529867    37618   -492249     
  Branches      64722     6941    -57781     
=============================================
- Hits          92782     1347    -91435     
+ Misses       426635    36105   -390530     
+ Partials      10450      166    -10284     
Flag Coverage Δ
uitests 3.58% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Fixes an issue in NsxResource.executeRequest where Network.Service
comparison failed when DeleteNsxNatRuleCommand was executed in a
different process. Due to serialization/deserialization, the
deserialized Network.Service instance was not equal to the static
instances Network.Service.StaticNat and Network.Service.PortForwarding,
causing the comparison to always return false.

fix
@wolfchkov wolfchkov force-pushed the fix-delete-nsx-rule-cmd-execution branch from 228376f to 57129ff Compare December 23, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants