[UI] Fix primary storage details display when the uuid has divergent pattern #12307
Conversation
|
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
There was a problem hiding this comment.
Pull request overview
This PR fixes the primary storage details page display issue when UUIDs contain special characters (such as colons in SolidFireShared provider pools) by properly encoding datastore IDs in router paths using encodeURIComponent.
- Applies URL encoding to storage pool and image store IDs in router links
- Ensures consistent encoding across multiple Vue components
- Fixes navigation issues for storage pools with non-standard UUID patterns
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ui/src/views/storage/SnapshotZones.vue | Encodes datastoreid in router links for both primary storage pools and image stores |
| ui/src/views/image/TemplateZones.vue | Encodes datastoreId when linking to storage pools from template zones |
| ui/src/views/image/IsoZones.vue | Encodes datastoreId when linking to storage pools from ISO zones |
| ui/src/components/view/VolumesTab.vue | Encodes storageid in router links from volumes table |
| ui/src/components/view/ListView.vue | Encodes both record.id and storageid in router links across list views |
| ui/src/components/view/InfoCard.vue | Encodes storageid in both route resolution check and router link generation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #12307 +/- ##
============================================
- Coverage 16.23% 16.23% -0.01%
+ Complexity 13379 13377 -2
============================================
Files 5657 5657
Lines 498865 498865
Branches 60545 60545
============================================
- Hits 81007 80992 -15
- Misses 408821 408842 +21
+ Partials 9037 9031 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
DaanHoogland
changed the title
|
@blueorangutan package |
|
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16105 |
…pattern (eg. for pools with SolidFireShared provider)
sureshanaparti
force-pushed
the
ui-primary-storage-uuid-issue
branch
from
fa48749 to
7dd7402
Compare
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16123 |
4 participants
Description
This PR fixes the primary storage details display when the uuid has different pattern (eg. for pools with SolidFireShared provider).
Fixes #12305
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Able to see the primary storage details page for SolidFireShared pool in the UI (Infrastructure -> Primary storage and Click on the primary storage).
Also, to reproduce/test, you can update the uuid of any of the existing pool to ' /iqn.2010-01.com.solidfire:3p53.test-001.007/0' and access the primary storage details from the UI.
How did you try to break this feature and the system with this change?