Add settings to mark cryptographic algorithms in vpn customer gateways as excluded or obsolete #12193

abh1sar · 2025-12-04T16:28:28Z

Description

This PR introduces several configuration settings using which an operator can mark certain cryptographic algorithms and parameters as excluded or obsolete for VPN Customer Gateway creation for Site-to-Site VPN.

Cloud providers following modern security frameworks (e.g., ISO 27001/27017) are required to enforce and communicate approved cryptographic standards. CloudStack currently accepts several weak or deprecated algorithms without guidance to users. This PR closes that gap by giving operators explicit control over what is disallowed vs discouraged, improving security posture without breaking existing deployments.

These settings are:

1. vpn.customer.gateway.excluded.encryption.algorithms
2. vpn.customer.gateway.excluded.hashing.algorithms
3. vpn.customer.gateway.excluded.ike.versions
4. vpn.customer.gateway.excluded.dh.group
5. vpn.customer.gateway.obsolete.encryption.algorithms
6. vpn.customer.gateway.obsolete.hashing.algorithms
7. vpn.customer.gateway.obsolete.ike.versions
8. vpn.customer.gateway.obsolete.dh.group

Details :

Excluded parameters are not shown to the Users in the Create and Update VPN Customer Gateway forms.
Obsolete parameters are shown with a warning
If a VPN gateway is already using an excluded or obsolete parameter:
a. A warning icon is displayed near to it's name with a message to change the obsolete parameter.
b. The Update VPN gateway form shows the setting with a warning to change it.
listVpnCustomerGateways api returns two new fields obsoleteparameters and excludedparameters containing the list of obsolete and excluded parameters that the gateway is using respectively.
A new field in the listCapabilities API response contains the list excluded and obsolete vpn customer gateway parameters, only if set.

Update:

Added a periodic task (Interval controlled by a configuration setting - disabled by default) to generate Alerts (Global) and events (per VPN Gateway) for existing VPN gateways that are using obsolete or excluded settings.

Documentation PR : apache/cloudstack-documentation#605

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

Alerts:

Events:

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2025-12-04T16:36:34Z

Codecov Report

❌ Patch coverage is 42.26804% with 112 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.56%. Comparing base (2600965) to head (d1466b4).
⚠️ Report is 55 commits behind head on main.

Files with missing lines	Patch %	Lines
...com/cloud/network/vpn/Site2SiteVpnManagerImpl.java	58.82%	52 Missing and 4 partials ⚠️
...in/java/com/cloud/server/ManagementServerImpl.java	0.00%	35 Missing ⚠️
...k/api/command/user/config/ListCapabilitiesCmd.java	0.00%	6 Missing ⚠️
...api/response/Site2SiteCustomerGatewayResponse.java	0.00%	6 Missing ⚠️
...src/main/java/com/cloud/api/ApiResponseHelper.java	0.00%	6 Missing ⚠️
.../cloudstack/api/response/CapabilitiesResponse.java	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #12193      +/-   ##
============================================
- Coverage     17.57%   17.56%   -0.01%     
- Complexity    15550    15655     +105     
============================================
  Files          5913     5916       +3     
  Lines        529427   530159     +732     
  Branches      64677    64786     +109     
============================================
+ Hits          93024    93126     +102     
- Misses       425940   426546     +606     
- Partials      10463    10487      +24

Flag	Coverage Δ
uitests	`3.57% <ø> (-0.02%)`	⬇️
unittests	`18.63% <42.26%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

abh1sar · 2025-12-04T17:42:39Z

@blueorangutan package

blueorangutan · 2025-12-04T17:44:04Z

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-12-04T18:59:51Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15920

nvazquez · 2025-12-08T12:19:24Z

@abh1sar can you please target this branch against main branch?

abh1sar · 2025-12-09T08:34:40Z

@blueorangutan package

blueorangutan · 2025-12-09T08:36:03Z

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-12-09T10:57:22Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 15958

…obsolete/excluded parameters

abh1sar · 2025-12-10T17:20:08Z

@blueorangutan package

blueorangutan · 2025-12-13T00:46:09Z

[SF] Trillian test result (tid-14975)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53648 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12193-t14975-kvm-ol8.zip
Smoke tests completed. 148 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_unsecure_vm_migration	`Error`	431.17	test_vm_life_cycle.py
test_02_unsecure_vm_migration	`Error`	431.19	test_vm_life_cycle.py
test_08_migrate_vm	`Error`	18.17	test_vm_life_cycle.py
test_01_migrate_vm_strict_tags_success	`Error`	66.50	test_vm_strict_host_tags.py

RosiKyu · 2025-12-16T13:59:10Z

@blueorangutan test

blueorangutan · 2025-12-16T14:00:04Z

@RosiKyu a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-12-17T04:59:32Z

[SF] Trillian test result (tid-15002)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 50851 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12193-t15002-kvm-ol8.zip
Smoke tests completed. 150 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

abh1sar · 2025-12-17T10:24:49Z

@blueorangutan package

blueorangutan · 2025-12-17T10:26:04Z

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-12-17T11:57:51Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16073

RosiKyu · 2025-12-19T15:18:16Z

@blueorangutan test

blueorangutan · 2025-12-19T15:20:04Z

@RosiKyu a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

RosiKyu · 2025-12-19T18:52:16Z

@abh1sar - looks like there's an issue with the smoketets. Could you please have a look?

blueorangutan · 2025-12-20T07:27:17Z

[SF] Trillian test result (tid-15030)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 55216 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12193-t15030-kvm-ol8.zip
Smoke tests completed. 149 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	24.57	test_kubernetes_clusters.py

RosiKyu · 2025-12-21T11:39:50Z

@blueorangutan test

blueorangutan · 2025-12-21T11:42:04Z

@RosiKyu a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-12-22T02:08:50Z

[SF] Trillian test result (tid-15038)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 49549 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12193-t15038-kvm-ol8.zip
Smoke tests completed. 147 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestClusterDRS>:setup	`Error`	0.00	test_cluster_drs.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	28.63	test_kubernetes_clusters.py
test_list_system_vms_metrics_history	`Failure`	0.18	test_metrics_api.py

RosiKyu · 2025-12-22T12:37:10Z

@blueorangutan test

blueorangutan · 2025-12-22T12:38:04Z

@RosiKyu a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-12-22T13:54:04Z

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

abh1sar · 2025-12-22T14:10:11Z

@blueorangutan package

blueorangutan · 2025-12-22T14:12:03Z

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

RosiKyu · 2025-12-22T14:24:09Z

@blueorangutan test

blueorangutan · 2025-12-22T14:26:04Z

@RosiKyu a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-12-22T15:49:49Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16125

blueorangutan · 2025-12-22T16:13:57Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16127

blueorangutan · 2025-12-23T04:26:15Z

[SF] Trillian test result (tid-15040)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53955 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12193-t15040-kvm-ol8.zip
Smoke tests completed. 147 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestClusterDRS>:setup	`Error`	0.00	test_cluster_drs.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	27.82	test_kubernetes_clusters.py
test_02_list_cpvm_vm	`Failure`	0.04	test_ssvm.py
test_04_cpvm_internals	`Failure`	0.05	test_ssvm.py

boring-cyborg bot added component:api component:management-server component:networking component:UI component:vpc labels Dec 4, 2025

abh1sar mentioned this pull request Dec 4, 2025

Add settings to mark cryptographic algorithms in vpn customer gateways as excluded or obsolete apache/cloudstack-documentation#605

Draft

abh1sar requested a review from nvazquez December 4, 2025 17:42

abh1sar added this to the 4.20.3 milestone Dec 4, 2025

DaanHoogland changed the base branch from 4.20 to main December 8, 2025 13:04

DaanHoogland changed the base branch from main to 4.22 December 8, 2025 13:05

DaanHoogland changed the base branch from 4.22 to 4.20 December 8, 2025 13:05

abh1sar added 4 commits December 8, 2025 23:16

Api changes to mark cryptographic parameters are excluded/obsolete

fdaca7f

UI changes

ad0f8cd

Added UT for Site2SiteVpnManagerImpl

62ee668

Fix ui after rebase

6bfda8a

abh1sar changed the base branch from 4.20 to main December 8, 2025 18:04

abh1sar force-pushed the vpn-cust-gw branch from 714b5b1 to 6bfda8a Compare December 8, 2025 18:05

nvazquez modified the milestones: 4.20.3, 4.23 Dec 8, 2025

Fix Site2SiteVpnManagerImplTest

313dcdc

Add a periodic task to generate alerts/events for vpn gateways using …

fe98a09

…obsolete/excluded parameters

abh1sar added 2 commits December 17, 2025 15:47

Fix dynamic changing of the scheduled task interval

cb7e89b

fix interval

6117774

abh1sar added 2 commits December 22, 2025 19:18

query ListCapabilitiesCmd by domainId

9ae56ff

update since

1468624

abh1sar added 2 commits December 22, 2025 19:36

fix capitalisation

f7a39d8

Merge remote-tracking branch 'origin/vpn-cust-gw' into vpn-cust-gw

d1466b4

Add settings to mark cryptographic algorithms in vpn customer gateways as excluded or obsolete #12193

Are you sure you want to change the base?

Add settings to mark cryptographic algorithms in vpn customer gateways as excluded or obsolete #12193

Conversation

abh1sar commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

abh1sar commented Dec 4, 2025

Uh oh!

blueorangutan commented Dec 4, 2025

Uh oh!

blueorangutan commented Dec 4, 2025

Uh oh!

nvazquez commented Dec 8, 2025

Uh oh!

abh1sar commented Dec 9, 2025

Uh oh!

blueorangutan commented Dec 9, 2025

Uh oh!

blueorangutan commented Dec 9, 2025

Uh oh!

abh1sar commented Dec 10, 2025

Uh oh!

blueorangutan commented Dec 13, 2025

Uh oh!

RosiKyu commented Dec 16, 2025

Uh oh!

blueorangutan commented Dec 16, 2025

Uh oh!

blueorangutan commented Dec 17, 2025

Uh oh!

abh1sar commented Dec 17, 2025

Uh oh!

blueorangutan commented Dec 17, 2025

Uh oh!

blueorangutan commented Dec 17, 2025

Uh oh!

RosiKyu commented Dec 19, 2025

Uh oh!

blueorangutan commented Dec 19, 2025

Uh oh!

RosiKyu commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blueorangutan commented Dec 20, 2025

Uh oh!

RosiKyu commented Dec 21, 2025

Uh oh!

blueorangutan commented Dec 21, 2025

Uh oh!

blueorangutan commented Dec 22, 2025

Uh oh!

RosiKyu commented Dec 22, 2025

Uh oh!

blueorangutan commented Dec 22, 2025

Uh oh!

blueorangutan commented Dec 22, 2025

Uh oh!

abh1sar commented Dec 22, 2025

Uh oh!

blueorangutan commented Dec 22, 2025

Uh oh!

RosiKyu commented Dec 22, 2025

Uh oh!

blueorangutan commented Dec 22, 2025

Uh oh!

blueorangutan commented Dec 22, 2025

Uh oh!

abh1sar commented Dec 4, 2025 •

edited

Loading

codecov bot commented Dec 4, 2025 •

edited

Loading

RosiKyu commented Dec 19, 2025 •

edited

Loading