Skip to content

sensitive information leak to log #12018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sureshanaparti merged 16 commits into from
Jan 28, 2026
Merged

sensitive information leak to log #12018

sureshanaparti merged 16 commits into from
Jan 28, 2026

Conversation

@YLChen-007
Copy link
Contributor

@YLChen-007 YLChen-007 commented Nov 7, 2025 •
edited by DaanHoogland
Loading

Description

This PR fixed sensitive information leak to log Fixes: #11985

@YLChen-007 YLChen-007 changed the base branch from main to 4.20 November 7, 2025 12:32
@codecov
Copy link

codecov bot commented Nov 7, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.24%. Comparing base (5bb5af4) to head (6fbc565).
⚠️ Report is 9 commits behind head on 4.20.

Files with missing lines Patch % Lines
...metal/networkservice/BaremetalPingPxeResource.java 0.00% 5 Missing ⚠️
utils/src/main/java/com/cloud/utils/UriUtils.java 0.00% 5 Missing ⚠️
.../networkservice/BaremetalKickStartPxeResource.java 0.00% 3 Missing ⚠️
...metal/networkservice/BaremetalDnsmasqResource.java 0.00% 2 Missing ⚠️
...nt/resource/consoleproxy/ConsoleProxyResource.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20   #12018      +/-   ##
============================================
- Coverage     16.24%   16.24%   -0.01%     
  Complexity    13397    13397              
============================================
  Files          5658     5658              
  Lines        499224   499249      +25     
  Branches      60595    60599       +4     
============================================
+ Hits          81098    81100       +2     
- Misses       409083   409105      +22     
- Partials       9043     9044       +1
Flag Coverage Δ
uitests 4.03% <ø> (ø)
unittests 17.10% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland
DaanHoogland approved these changes Nov 7, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, all comments nitpicking

@DaanHoogland DaanHoogland added this to the 4.20.3 milestone Nov 7, 2025
YLChen-007 and others added 10 commits November 7, 2025 21:50
@YLChen-007 @DaanHoogland
Update agent/src/main/java/com/cloud/agent/resource/consoleproxy/Cons…
7e09770 
…oleProxyResource.java

Co-authored-by: dahn <daan.hoogland@gmail.com>
@YLChen-007 @DaanHoogland
Update core/src/main/java/com/cloud/storage/template/HttpTemplateDown…
08b1d9e 
…loader.java

Co-authored-by: dahn <daan.hoogland@gmail.com>
@YLChen-007 @DaanHoogland
Update engine/schema/src/main/java/com/cloud/upgrade/DatabaseCreator.…
e084644 
…java

Co-authored-by: dahn <daan.hoogland@gmail.com>
@YLChen-007 @DaanHoogland
Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremeta…
4a614b6 
…l/networkservice/BaremetalDnsmasqResource.java

Co-authored-by: dahn <daan.hoogland@gmail.com>
@YLChen-007 @DaanHoogland
Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremeta…
c97662d 
…l/networkservice/BaremetalDnsmasqResource.java

Co-authored-by: dahn <daan.hoogland@gmail.com>
@YLChen-007 @DaanHoogland
Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremeta…
0e85b58 
…l/networkservice/BaremetalKickStartPxeResource.java

Co-authored-by: dahn <daan.hoogland@gmail.com>
@YLChen-007 @DaanHoogland
Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremeta…
badf6bc 
…l/networkservice/BaremetalPingPxeResource.java

Co-authored-by: dahn <daan.hoogland@gmail.com>
@YLChen-007 @DaanHoogland
Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremeta…
d9f18b6 
…l/networkservice/BaremetalPingPxeResource.java

Co-authored-by: dahn <daan.hoogland@gmail.com>
@YLChen-007 @DaanHoogland
Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremeta…
460e71e 
…l/networkservice/BaremetalPingPxeResource.java

Co-authored-by: dahn <daan.hoogland@gmail.com>
@YLChen-007 @DaanHoogland
Update utils/src/main/java/com/cloud/utils/UriUtils.java
53e1861 
Co-authored-by: dahn <daan.hoogland@gmail.com>
@DaanHoogland DaanHoogland linked an issue Nov 12, 2025 that may be closed by this pull request
Credential Leakage through Logging Statements #11985
Closed
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@DaanHoogland @abh1sar
Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremeta…
830a5a5 
…l/networkservice/BaremetalKickStartPxeResource.java

Co-authored-by: Abhisar Sinha <63767682+abh1sar@users.noreply.github.com>
@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jan 5, 2026

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jan 5, 2026

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

sureshanaparti
sureshanaparti reviewed Jan 5, 2026
View reviewed changes
@blueorangutan
Copy link

blueorangutan commented Jan 5, 2026

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16254

@nvazquez
Copy link
Contributor

nvazquez commented Jan 26, 2026

Hi @YLChen-007 thanks for the PR - can you please address the review comments?

@YLChen-007
Copy link
Contributor Author

YLChen-007 commented Jan 27, 2026

Hi @YLChen-007 thanks for the PR - can you please address the review comments?

Yes, I solved this problem. Please check it.

@DaanHoogland @sureshanaparti
Apply suggestions from code review
6fbc565 
Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>
sureshanaparti
sureshanaparti approved these changes Jan 27, 2026
View reviewed changes
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@sureshanaparti
Copy link
Contributor

sureshanaparti commented Jan 27, 2026

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jan 27, 2026

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jan 27, 2026

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16556

@borisstoyanov
Copy link
Contributor

borisstoyanov commented Jan 27, 2026

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Jan 27, 2026

@borisstoyanov a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Jan 28, 2026

[SF] Trillian test result (tid-15308)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 52562 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12018-t15308-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_isolate_network_FW_PF_default_routes_egress_true Failure 98.54 test_routers_network_ops.py

@sureshanaparti sureshanaparti merged commit dd0b863 into apache:4.20 Jan 28, 2026
23 of 26 checks passed
@sureshanaparti sureshanaparti mentioned this pull request Jan 28, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@nvazquez nvazquez nvazquez approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

+1 more reviewer

@abh1sar abh1sar abh1sar left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component:agent

Projects

None yet

Milestone

4.20.3

Development

Successfully merging this pull request may close these issues.

Credential Leakage through Logging Statements

8 participants

@YLChen-007 @DaanHoogland @blueorangutan @nvazquez @sureshanaparti @borisstoyanov @abh1sar @cyl-auth