-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix Host Password Exposed in Command-Line Logging #12016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Host Password Exposed in Command-Line Logging #12016
Conversation
...ud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixUpdateHostPasswordCommandWrapper.java
Outdated
Show resolved
Hide resolved
…or/xenserver/resource/wrapper/xenbase/CitrixUpdateHostPasswordCommandWrapper.java Co-authored-by: dahn <daan.hoogland@gmail.com>
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #12016 +/- ##
============================================
+ Coverage 16.18% 16.24% +0.05%
- Complexity 13305 13399 +94
============================================
Files 5657 5658 +1
Lines 498466 499246 +780
Branches 60491 60599 +108
============================================
+ Hits 80696 81099 +403
- Misses 408789 409102 +313
- Partials 8981 9045 +64
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
...ud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixUpdateHostPasswordCommandWrapper.java
Outdated
Show resolved
Hide resolved
…or/xenserver/resource/wrapper/xenbase/CitrixUpdateHostPasswordCommandWrapper.java Co-authored-by: Abhisar Sinha <63767682+abh1sar@users.noreply.github.com>
sureshanaparti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16558 |
This PR fixes Host Password Exposed in Command-Line Logging During Password Update Operations. Fixes: #11989