Skip to content

Conversation

@YLChen-007
Copy link
Contributor

@YLChen-007 YLChen-007 commented Nov 7, 2025

This PR fixes Host Password Exposed in Command-Line Logging During Password Update Operations. Fixes: #11989

…or/xenserver/resource/wrapper/xenbase/CitrixUpdateHostPasswordCommandWrapper.java

Co-authored-by: dahn <daan.hoogland@gmail.com>
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland DaanHoogland added this to the 4.20.3 milestone Nov 7, 2025
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.24%. Comparing base (e90e436) to head (f547e85).
⚠️ Report is 88 commits behind head on 4.20.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #12016      +/-   ##
============================================
+ Coverage     16.18%   16.24%   +0.05%     
- Complexity    13305    13399      +94     
============================================
  Files          5657     5658       +1     
  Lines        498466   499246     +780     
  Branches      60491    60599     +108     
============================================
+ Hits          80696    81099     +403     
- Misses       408789   409102     +313     
- Partials       8981     9045      +64     
Flag Coverage Δ
uitests 4.03% <ø> (+0.02%) ⬆️
unittests 17.10% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…or/xenserver/resource/wrapper/xenbase/CitrixUpdateHostPasswordCommandWrapper.java

Co-authored-by: Abhisar Sinha <63767682+abh1sar@users.noreply.github.com>
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@sureshanaparti
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16558

@DaanHoogland DaanHoogland merged commit c0b5358 into apache:4.20 Jan 27, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Security: Host Password Exposed in Command-Line Logging During Password Update Operations

6 participants