alert: fix type ID for alerts #11350

shwstppr · 2025-07-30T12:24:45Z

Description

Alert types ALERT.VM.SNAPSHOT, ALERT.VR.PUBLIC.IFACE.MTU and ALERT.VR.PRIVATE.IFACE.MTU are all having type value 32.

TBD: will this cause any sort of issue?

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2025-07-30T13:13:28Z

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 16.24%. Comparing base (8db065a) to head (6be21fb).
⚠️ Report is 21 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
.../src/main/java/com/cloud/event/AlertGenerator.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #11350      +/-   ##
============================================
- Coverage     16.24%   16.24%   -0.01%     
- Complexity    13396    13397       +1     
============================================
  Files          5658     5658              
  Lines        499169   499273     +104     
  Branches      60579    60600      +21     
============================================
+ Hits          81087    81101      +14     
- Misses       409041   409128      +87     
- Partials       9041     9044       +3

Flag	Coverage Δ
uitests	`4.03% <ø> (-0.01%)`	⬇️
unittests	`17.10% <66.66%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

shwstppr · 2025-07-31T15:06:41Z

@blueorangutan package

blueorangutan · 2025-07-31T15:08:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-31T16:09:55Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14494

DaanHoogland · 2025-08-01T07:05:30Z

@blueorangutan test

blueorangutan · 2025-08-01T07:06:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-08-01T20:21:03Z

[SF] Trillian test result (tid-13999)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 45122 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11350-t13999-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland · 2025-08-02T10:18:22Z

api/src/main/java/org/apache/cloudstack/alert/AlertService.java

+        public static final AlertType ALERT_TYPE_VR_PUBLIC_IFACE_MTU = new AlertType((short)33, "ALERT.VR.PUBLIC.IFACE.MTU", true);
+        public static final AlertType ALERT_TYPE_VR_PRIVATE_IFACE_MTU = new AlertType((short)34, "ALERT.VR.PRIVATE.IFACE.MTU", true);


like Capacity.CAPACITY_TYPE_MEMORY all these numbers should be mnenomic. I think. an enum is in order, but a growable Set could be used as well, to make it more dynamic. btw I don’t think the Alert types should be gotten from external entities to this component (like Capacity) but external components should at best be allowed to register types, or else use type provided by the AlertService . I hope this makes sense.

Also all this said, this is not a rejection of this change, just some remarks on the design quality/techdebt we are looking at.

DaanHoogland · 2025-12-31T12:47:41Z

@shwstppr , any testing needed here?

shwstppr · 2026-01-07T08:00:05Z

@DaanHoogland I can't say what kind of testing we can do other than our integration tests. The only case I see this may cause an issue is when someone has already added some external automation based on the alert in value.

Updated base branch to 4.20

@blueorangutan package

blueorangutan · 2026-01-07T08:02:05Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-01-07T09:47:02Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16285

DaanHoogland · 2026-01-07T11:22:06Z

The only case I see this may cause an issue is when someone has already added some external automation based on the alert in value.

ok, one for the release notes then (cc @abh1sar )

DaanHoogland · 2026-01-07T11:22:16Z

@blueorangutan test

blueorangutan · 2026-01-07T11:24:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-01-08T04:59:24Z

[SF] Trillian test result (tid-15132)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 60323 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11350-t15132-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

sureshanaparti · 2026-01-08T08:50:03Z

api/src/main/java/org/apache/cloudstack/alert/AlertService.java

        public static final AlertType ALERT_TYPE_VM_SNAPSHOT = new AlertType((short)32, "ALERT.VM.SNAPSHOT", true);
-        public static final AlertType ALERT_TYPE_VR_PUBLIC_IFACE_MTU = new AlertType((short)32, "ALERT.VR.PUBLIC.IFACE.MTU", true);
-        public static final AlertType ALERT_TYPE_VR_PRIVATE_IFACE_MTU = new AlertType((short)32, "ALERT.VR.PRIVATE.IFACE.MTU", true);
+        public static final AlertType ALERT_TYPE_VR_PUBLIC_IFACE_MTU = new AlertType((short)33, "ALERT.VR.PUBLIC.IFACE.MTU", true);


@shwstppr any db upgrade is needed for the records with alert type 32 and not belonging to vm snapshot?

@sureshanaparti , how would we make the distinction?

maybe, based on the subject or content in the alerts.

ok, could be done (maybe). I just wonder if this is worth the trouble. Alerts are just that ; a one of alerting of the operator to signal the system needs attention. I am not sure maintaining old alerts is a worthwhile endeavour.
Also, we would need to be deadsure the conversion is correct and complete for it to make any sense.

@DaanHoogland @sureshanaparti I think it can be done with some confidence as alert DB entry does contain both type and name,

mysql> SELECT * FROM alert LIMIT 4\G *************************** 1. row *************************** id: 1 uuid: 6b0e308c-5d98-4574-98fe-479b9c70d633 type: 14 cluster_id: NULL pod_id: NULL data_center_id: 0 subject: Management network CIDR is not configured originally. Set it default to 192.168.1.0/24 sent_count: 1 created: 2025-12-22 10:31:21 last_sent: 2025-12-22 10:31:21 resolved: NULL archived: 0 name: ALERT.MANAGEMENT content: *************************** 2. row *************************** id: 2 uuid: 8726e2ee-ebbd-44c8-9a98-38bf725e97e4 type: 14 cluster_id: NULL pod_id: NULL data_center_id: 0 subject: Management server node 127.0.0.1 is up sent_count: 1 created: 2025-12-22 10:31:24 last_sent: 2025-12-22 10:31:24 resolved: NULL archived: 0 name: ALERT.MANAGEMENT content: ...

but some issues are:

either we add a 4.20.2.0 to 4.20.3.0 path or target the changes for 4.22 branch.

with newer versions more types have been added. 4.22 already has 3 new.

this numeric constant approach will have the same issue again sooner or later.

I'm okay to close this and let things as it is as we don't have an issue reported and only something I saw wrong

I think we must do this but on main/23 is better.

ALERT.VM.SNAPSHOT, ALERT.VR.PUBLIC.IFACE.MTU and ALERT.VR.PRIVATE.IFACE.MTU are all having type value 32. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

….PRIVATE.IFACE.MTU

sureshanaparti · 2026-01-27T11:26:24Z

@shwstppr updated the upgrade path for the alerts, please check. cc @DaanHoogland @borisstoyanov

sureshanaparti · 2026-01-27T11:26:42Z

@blueorangutan package

blueorangutan · 2026-01-27T11:28:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

shwstppr · 2026-01-27T11:30:21Z

@sureshanaparti can you please create a new PR with your changes?

blueorangutan · 2026-01-27T12:23:49Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16563

sureshanaparti · 2026-01-27T12:30:35Z

@sureshanaparti can you please create a new PR with your changes?

created new PR: #12527 cc @DaanHoogland @Pearl1594 @shwstppr

boring-cyborg bot added the component:api label Jul 30, 2025

shwstppr marked this pull request as draft July 30, 2025 12:25

shwstppr requested review from DaanHoogland, Pearl1594 and sureshanaparti July 30, 2025 12:25

DaanHoogland approved these changes Jul 30, 2025

View reviewed changes

Pearl1594 approved these changes Jul 30, 2025

View reviewed changes

shwstppr marked this pull request as ready for review July 31, 2025 15:06

shwstppr mentioned this pull request Aug 1, 2025

api,server: allow configuring repetitive alerts #11325

Open

14 tasks

DaanHoogland reviewed Aug 2, 2025

View reviewed changes

shwstppr changed the base branch from 4.19 to 4.20 January 7, 2026 07:57

shwstppr added this to the 4.20.3 milestone Jan 7, 2026

sureshanaparti reviewed Jan 8, 2026

View reviewed changes

borisstoyanov self-assigned this Jan 26, 2026

alert: fix type ID for alerts

6f7cc67

ALERT.VM.SNAPSHOT, ALERT.VR.PUBLIC.IFACE.MTU and ALERT.VR.PRIVATE.IFACE.MTU are all having type value 32. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Added upgrade path for the alerts ALERT.VR.PUBLIC.IFACE.MTU, ALERT.VR…

6be21fb

….PRIVATE.IFACE.MTU

sureshanaparti force-pushed the alerttype-id-issue branch from 21a7973 to 6be21fb Compare January 27, 2026 11:25

shwstppr closed this Jan 27, 2026

DaanHoogland deleted the alerttype-id-issue branch January 27, 2026 14:17

		public static final AlertType ALERT_TYPE_VR_PUBLIC_IFACE_MTU = new AlertType((short)33, "ALERT.VR.PUBLIC.IFACE.MTU", true);
		public static final AlertType ALERT_TYPE_VR_PRIVATE_IFACE_MTU = new AlertType((short)34, "ALERT.VR.PRIVATE.IFACE.MTU", true);

alert: fix type ID for alerts #11350

alert: fix type ID for alerts #11350

Uh oh!

Conversation

shwstppr commented Jul 30, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shwstppr commented Jul 31, 2025

Uh oh!

blueorangutan commented Jul 31, 2025

Uh oh!

blueorangutan commented Jul 31, 2025

Uh oh!

DaanHoogland commented Aug 1, 2025

Uh oh!

blueorangutan commented Aug 1, 2025

Uh oh!

blueorangutan commented Aug 1, 2025

Uh oh!

DaanHoogland Aug 2, 2025

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Dec 31, 2025

Uh oh!

shwstppr commented Jan 7, 2026

Uh oh!

blueorangutan commented Jan 7, 2026

Uh oh!

blueorangutan commented Jan 7, 2026

Uh oh!

DaanHoogland commented Jan 7, 2026

Uh oh!

DaanHoogland commented Jan 7, 2026

Uh oh!

blueorangutan commented Jan 7, 2026

Uh oh!

blueorangutan commented Jan 8, 2026

Uh oh!

sureshanaparti Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

sureshanaparti Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

shwstppr Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Jan 27, 2026

Uh oh!

sureshanaparti commented Jan 27, 2026

Uh oh!

blueorangutan commented Jan 27, 2026

Uh oh!

shwstppr commented Jan 27, 2026

Uh oh!

blueorangutan commented Jan 27, 2026

Uh oh!

sureshanaparti commented Jan 27, 2026

Uh oh!

Reviewers

codecov bot commented Jul 30, 2025 •

edited

Loading