Update install.sh #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bitsonwheels
commented
Sep 12, 2025
Bitsonwheels
commented
- Fix local interface detection for /etc/netplan/01-netcfg.yaml creation
- Fix System Version Code detection for right apt source creation
- Fix GPG key verification
- add gpg to install apps
- Fix local interface detection for /etc/netplan/01-netcfg.yaml creation - Fix System Version Code detection for right apt source creation - Fix GPG key verification - add gpg to install apps
fix "No such file or directory" and apparmor error
rohityadavcloud
requested changes
Sep 19, 2025
Member
rohityadavcloud
left a comment
rohityadavcloud
left a comment
There was a problem hiding this comment.
Some changes make sense, but largely other changes are not acceptable.
|
|
||
| ```bash | ||
| curl -sL https://c8k.in/stall.sh | bash | ||
| curl -sL https://raw.githubusercontent.com/Bitsonwheels/cloudstack-installer/refs/heads/main/install.sh | bash |
Member
There was a problem hiding this comment.
Can't hardcode to this repo
|
|
||
| ```bash | ||
| curl -o install.sh https://c8k.in/stall.sh | ||
| curl -o install.sh https://raw.githubusercontent.com/Bitsonwheels/cloudstack-installer/refs/heads/main/install.sh |
Member
There was a problem hiding this comment.
Can't hardcode to this repo
| NAME=$(sed -rn 's|^deb\s+\S+\s+(\w+)\s+main.*$|\1|p' /etc/apt/sources.list | head -n 1) | ||
|
|
||
| mkdir -p /etc/apt/keyrings | ||
| wget -O - https://download.cloudstack.org/release.asc | sudo tee /etc/apt/trusted.gpg.d/cloudstack.asc |
Member
|
cc @sudo87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.