CLIMATE-912 Upgrade mccSearch code from Python2 > 3

[lewismc]

This issue addresses CLIMATE-912

[lewismc]

@kwhitehall if you are able to pull this PR locally and try it out with some test data (and reference the data here so I can also try it out) it would be very much appreciated.

[kwhitehall]

Ack'ed @lewismc

[lewismc]

Thank you @kwhitehall

[lewismc]

Hi @kwhitehall I just went to look at some more OCW code and my local branch was set to this issue. I had to come here to remind myself what the issue was about. Did you get any time at all to take a look through this?

[kwhitehall]

Hey @lewismc
Tested and found the following:

1. need to convert this spaces to tabs in this folder
2. updat code to reduce the number of datasets needed to test.
   Code for test can be obtained at the this Google Drive loc

Note that I did a hacky update cause another error flagged in dataset_processor.py by changing them to:
spatial_indices_true = np.where(spatial_values.mask.all)
spatial_indices_false = np.where(not spatial_values.mask.all)
I haven't included these as something to include in this PR as more investigation needs to be done to ensure that this doesn't break the code otherwise.

The PR has been pushed to my local here.
I'll work on pushing it to your PR. Do you have direction on this?

[lewismc]

Hi @kwhitehall I am sorry I didn't get back to you on this.
We need to update the PR to resolve conflicts. I will take a wee look on Monday.

[cclauss]

Recommendation to change print(("-" * 80)) to print("-" * 80) in eight places. The double nested parens (( )) are not needed and only slow down your reader. Repeated on lines: 60, 71, 73, 76, 78, 81, 84, 107.

[cclauss]

Recommendation to change print(("-" * 80)) to print("-" * 80) in eight places. The double nested parens (( )) are not needed and only slow down your reader. Repeated on lines: 64, 75, 77, 80, 82, 86, 89, 112.