Open
Conversation
anzdaddy
reviewed
Feb 18, 2020
|
I think this problem could be solved in a different and possibly simpler way by implementing it as a package on top of the log library. Imagine a library which exposes:
It would be able to be achieved with no modification to the logging library itself, and then becomes optional to follow the exact pattern of one log line per client request depending on the needs of the consumer |
anzopensource
pushed a commit
that referenced
this pull request
Feb 7, 2023
* Upgrade otel metrics to v0.35 * Tidy!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added API for canonical log and tests.
This is part of #16