Tony/193_unexpected_directory

[tonypioneer]

Pull Request Details

What issue does this PR address

• Fixed the issue that uploaded file appears in the unexpected directory.

Associated Issue

• This PR relates to issue SOLID UI: Uploaded file appears in unexpected directory #193

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Build and run the app, and then upload some files on Files page.

Checklist

Complete the check-list below to ensure your branch is ready for PR.

• Screenshots included in linked issue SOLID UI: Uploaded file appears in unexpected directory #193
• Changes adhere to the style and coding guidelines
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• Any dependent changes have been merged and published in downstream modules
• The update contains no confidential information
• The update has no duplicated content
• No lint check errors are related to these changes (make prep or flutter analyze lib)
• Integration test dart test output or screenshot included in issue #
• I tested the PR on these devices:
  • Android
  • iOS
  • Linux
  • MacOS
  • Windows
  • Web
• I have identified reviewers
• The PR has been approved by reviewers

Finalising

Once PR discussion is complete and reviewers have approved:

• Merge dev into the this branch
• Resolve any conflicts
• Add a one line summary into the CHANGELOG.md
• Push to the git repository and review
• Merge the PR into dev

[cdawei]

I suggest we hold this PR as the issue will probably be resolved automatically once #153 is fixed?

[tonypioneer]

I suggest we hold this PR as the issue will probably be resolved automatically once #153 is fixed?

Hi @cdawei, I'm not very sure about that because PR for issue #153 is based on the PR for this issue. #153 contains the fixing for this issue as well.

[cdawei]

Hi @cdawei, I'm not very sure about that because PR for issue #153 is based on the PR for this issue. #153 contains the fixing for this issue as well.

Shall we change the merge target of PR #198 to branch dev so that when the PR for #153 is merged, it will also include the fix for this issue? (As the root cause of this issue is very likely #153.)

[tonypioneer]

Hi @cdawei, I'm not very sure about that because PR for issue #153 is based on the PR for this issue. #153 contains the fixing for this issue as well.

Shall we change the merge target of PR #198 to branch dev so that when the PR for #153 is merged, it will also include the fix for this issue? (As the root cause of this issue is very likely #153.)

I think if we change the merge target to dev, it will also contain the code changes in this PR. Because I created the branch for #153 based on the branch for #193, and all the changes are also based on the code in #193. So after we merge #153 to dev, there will be no file changes in #193, and we can directly close this PR.

[cdawei]

I think if we change the merge target to dev, it will also contain the code changes in this PR. Because I created the branch for #153 based on the branch for #193, and all the changes are also based on the code in #193. So after we merge #153 to dev, there will be no file changes in #193, and we can directly close this PR.

This is exactly what I would like to suggest, sorry for not being clear in previous comments.

[tonypioneer]

I think if we change the merge target to dev, it will also contain the code changes in this PR. Because I created the branch for #153 based on the branch for #193, and all the changes are also based on the code in #193. So after we merge #153 to dev, there will be no file changes in #193, and we can directly close this PR.

This is exactly what I would like to suggest, sorry for not being clear in previous comments.

No worries. I've changed the merge target to dev. Thanks @cdawei for the clarification.

[cdawei]

Feel free to close this PR as issue #193 will be resolved in PR #198.

[tonypioneer]

Close as this issue will be resolved in PR #198.