Skip to content

Conversation

@tonypioneer
Copy link
Collaborator

Pull Request Details

What issue does this PR address

  • Added a popup to inform users that the file they are about to download is located in another application’s data folder and cannot be decrypted.

Associated Issue

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Manually set the home directory of the file browser to the root directory of the POD, and then build and run the app.

Checklist

Complete the check-list below to ensure your branch is ready for PR.

  • Screenshots included in linked issue SOLID UI: Downloading does not decrypt files from another app's data folder #154
  • Changes adhere to the style and coding guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • The update contains no confidential information
  • The update has no duplicated content
  • No lint check errors are related to these changes (make prep or flutter analyze lib)
  • Integration test dart test output or screenshot included in issue #
  • I tested the PR on these devices:
    • Android
    • iOS
    • Linux
    • MacOS
    • Windows
    • Web
  • I have identified reviewers
  • The PR has been approved by reviewers

Finalising

Once PR discussion is complete and reviewers have approved:

  • Merge dev into the this branch
  • Resolve any conflicts
  • Add a one line summary into the CHANGELOG.md
  • Push to the git repository and review
  • Merge the PR into dev

…is located in another application’s data folder and cannot be decrypted
Copy link
Contributor

@cdawei cdawei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tony. The changes look good to me except one point (as commented below).

@tonypioneer tonypioneer requested a review from cdawei February 6, 2026 05:28
@tonypioneer
Copy link
Collaborator Author

To better debug the code and fix this issue, I need to merge branch tony/153_refactor_file_browsing_code into this branch and rebase it onto branch tony/153_refactor_file_browsing_code.

@tonypioneer tonypioneer requested a review from cdawei February 8, 2026 13:36
@tonypioneer tonypioneer changed the base branch from dev to tony/153_refactor_file_browsing_code February 8, 2026 13:37
@tonypioneer tonypioneer requested a review from cdawei February 9, 2026 05:14
Copy link
Contributor

@cdawei cdawei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, thanks Tony.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SOLID UI: Downloading does not decrypt files from another app's data folder

3 participants