Skip to content

Tony/186 migration #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gjwgit merged 6 commits into from
Feb 3, 2026
Merged

Tony/186 migration #569

gjwgit merged 6 commits into from
Feb 3, 2026

Conversation

@tonypioneer
Copy link
Collaborator

@tonypioneer tonypioneer commented Jan 30, 2026

Pull Request Details

What issue does this PR address

  • Migrated security key related UI elements to SolidUI.

Associated Issue

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Build and run the app.

Checklist

Complete the check-list below to ensure your branch is ready for PR.

  • Screenshots included in linked issue SOLIDUI: Migrate SecurityKeyUi(), SecretTextField() and SecurityColors to SolidUI solidui#186
  • Changes adhere to the style and coding guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • The update contains no confidential information
  • The update has no duplicated content
  • No lint check errors are related to these changes (make prep or flutter analyze lib)
  • Integration test dart test output or screenshot included in issue #
  • I tested the PR on these devices:
    • Android
    • iOS
    • Linux
    • MacOS
    • Windows
    • Web
  • I have identified reviewers
  • The PR has been approved by reviewers

Finalising

Once PR discussion is complete and reviewers have approved:

  • Merge dev into the this branch
  • Resolve any conflicts
  • Add a one line summary into the CHANGELOG.md
  • Push to the git repository and review
  • Merge the PR into dev

@tonypioneer tonypioneer requested a review from gjwgit January 30, 2026 08:55
@tonypioneer tonypioneer linked an issue Jan 30, 2026 that may be closed by this pull request
SOLIDUI: Migrate SecurityKeyUi(), SecretTextField() and SecurityColors to SolidUI anusii/solidui#186
Closed
This was referenced Feb 2, 2026
Closed
Merged
@jesscmoore jesscmoore self-requested a review February 2, 2026 01:40
@jesscmoore
Copy link
Collaborator

jesscmoore commented Feb 2, 2026

See review in related solidui PR anusii/solidui#187

tonypioneer and others added 4 commits February 2, 2026 20:11
@tonypioneer
Merge branch 'dev' of https://github.com/anusii/solidpod into tony/18…
2d6e954 
…6_migration

# Conflicts:
#	example/lib/home.dart
#	lib/src/solid/constants/ui.dart
#	lib/src/widgets/ind_webid_input_dialog.dart
#	pubspec.yaml
@tonypioneer
Fix the issue that SecurityKeyUI, SecurityStrings, and changeKeyPopup…
dcfcaa5 
… are missing
@tonypioneer
Lint
2a9b2b9
@jesscmoore
use dropdown colors not security colors in webid recipient dropdown
805647e
jesscmoore
jesscmoore approved these changes Feb 3, 2026
View reviewed changes
Copy link
Collaborator

@jesscmoore jesscmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tonypioneer - tested in notepad - worked great after your fixes!

In notepad I used jess/354_use_solidui_windowsize to source WindowSize from solidui, and with solidui and solidpod pointed to tony/186_migration.
This is a breaking change for notepad, and notepad jess/354_use_solidui_windowsize will need merging afterwards.

gjwgit
gjwgit approved these changes Feb 3, 2026
View reviewed changes
Copy link
Contributor

@gjwgit gjwgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with healthpod, geopod, - all good.

@gjwgit gjwgit merged commit 8f129e1 into dev Feb 3, 2026
20 checks passed
@gjwgit gjwgit deleted the tony/186_migration branch February 3, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gjwgit gjwgit gjwgit approved these changes

@jesscmoore jesscmoore jesscmoore approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SOLIDUI: Migrate SecurityKeyUi(), SecretTextField() and SecurityColors to SolidUI

3 participants

@tonypioneer @jesscmoore @gjwgit