Release #2115
Release #2115
Conversation
* refactor: remove rbush dependency Removes the `rbush` dependency and all related logic from the codebase. This includes: - Deleting the `RBushNode` component. - Removing `rbush` logic from `CanvasRendererPlugin` and `SelectablePlugin`. - Updating documentation to remove mentions of `rbush`. * fix(lint): fix linting errors Removes unused imports from `CanvasRendererPlugin.ts` and fixes a Prettier error. * chore: fix lint error --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: wang1212 <mrwang1212@126.com>
* perf: batch update attributes * perf: batch update attributes * 0.0.1-0 * chore: add changeset * chore: revert change --------- Co-authored-by: yunchen.wy <yunchen.wy@antgroup.com> Co-authored-by: wang1212 <mrwang1212@126.com>
|
Summary of ChangesHello @wang1212, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant refactoring effort to remove legacy RBush spatial indexing code across several core packages, streamlining the rendering pipeline and object querying. Concurrently, it introduces a new experimental API for batch attribute updates, aiming to improve performance for complex rendering scenarios. The changes impact how dirty rectangle rendering and object selection are handled, moving towards a more direct bounding box-based approach. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the legacy RBush spatial indexing system from the rendering pipeline, specifically impacting dirty rectangle rendering and spatial queries in CanvasRendererPlugin and SelectablePlugin. The changes involve deleting RBush-related interfaces, properties, and logic, with elementsFromBBox now handling spatial queries without RBush. Additionally, an experimental setAttributes API is introduced in DisplayObject for batch attribute updates, offering an option to skip event dispatching for performance. Review comments highlight a leftover commented-out return statement in the setAttributes method and critically note that the documentation for elementsFromBBox still claims it is "fast," which is misleading given the performance regression from an RBush-based lookup to an O(n) scene graph traversal.
No description provided.