Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

This change removes the rbush dependency and all related logic from the codebase. The RBushNode component has been deleted, and the CanvasRendererPlugin and SelectablePlugin have been refactored to use existing methods for spatial queries. The documentation has also been updated to reflect these changes.


PR created automatically by Jules for task 11034485319737824727 started by @wang1212

Removes the `rbush` dependency and all related logic from the codebase.

This includes:
- Deleting the `RBushNode` component.
- Removing `rbush` logic from `CanvasRendererPlugin` and `SelectablePlugin`.
- Updating documentation to remove mentions of `rbush`.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@changeset-bot
Copy link

changeset-bot bot commented Dec 24, 2025

⚠️ No Changeset found

Latest commit: 21a11cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-labs-jules bot and others added 2 commits December 24, 2025 02:57
Removes unused imports from `CanvasRendererPlugin.ts` and fixes a Prettier error.
@wang1212 wang1212 marked this pull request as ready for review December 24, 2025 07:45
@wang1212 wang1212 changed the base branch from master to release December 24, 2025 07:46
@wang1212 wang1212 merged commit 2a76f9a into release Dec 24, 2025
4 checks passed
@wang1212 wang1212 deleted the jules/remove-rbush-dependency-11034485319737824727 branch December 24, 2025 07:47
@hustcc
Copy link
Member

hustcc commented Dec 24, 2025

@wang1212 这个有带来什么收益不?不会出 bug 吧?

@wang1212
Copy link
Member

@wang1212 这个有带来什么收益不?不会出 bug 吧?

之前 g-lite 已经把 rbush 依赖移除掉了,这个 pr 只是把一些子包的遗留代码清理了下,应该不会有问题

wang1212 added a commit that referenced this pull request Dec 24, 2025
* chore: fix docs dependency version exception

* Remove rbush dependency (#2113)

* refactor: remove rbush dependency

Removes the `rbush` dependency and all related logic from the codebase.

This includes:
- Deleting the `RBushNode` component.
- Removing `rbush` logic from `CanvasRendererPlugin` and `SelectablePlugin`.
- Updating documentation to remove mentions of `rbush`.

* fix(lint): fix linting errors

Removes unused imports from `CanvasRendererPlugin.ts` and fixes a Prettier error.

* chore: fix lint error

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: wang1212 <mrwang1212@126.com>

* chore: add changeset

* perf: batch update attributes (#2001)

* perf: batch update attributes

* perf: batch update attributes

* 0.0.1-0

* chore: add changeset

* chore: revert change

---------

Co-authored-by: yunchen.wy <yunchen.wy@antgroup.com>
Co-authored-by: wang1212 <mrwang1212@126.com>

* chore(release): bump version (#2114)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: huiyu.zjt <Alexzjt@users.noreply.github.com>
Co-authored-by: yunchen.wy <yunchen.wy@antgroup.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants