-
Notifications
You must be signed in to change notification settings - Fork 230
Remove rbush dependency #2113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove rbush dependency #2113
Conversation
Removes the `rbush` dependency and all related logic from the codebase. This includes: - Deleting the `RBushNode` component. - Removing `rbush` logic from `CanvasRendererPlugin` and `SelectablePlugin`. - Updating documentation to remove mentions of `rbush`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
|
Removes unused imports from `CanvasRendererPlugin.ts` and fixes a Prettier error.
|
@wang1212 这个有带来什么收益不?不会出 bug 吧? |
之前 g-lite 已经把 rbush 依赖移除掉了,这个 pr 只是把一些子包的遗留代码清理了下,应该不会有问题 |
* chore: fix docs dependency version exception * Remove rbush dependency (#2113) * refactor: remove rbush dependency Removes the `rbush` dependency and all related logic from the codebase. This includes: - Deleting the `RBushNode` component. - Removing `rbush` logic from `CanvasRendererPlugin` and `SelectablePlugin`. - Updating documentation to remove mentions of `rbush`. * fix(lint): fix linting errors Removes unused imports from `CanvasRendererPlugin.ts` and fixes a Prettier error. * chore: fix lint error --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: wang1212 <mrwang1212@126.com> * chore: add changeset * perf: batch update attributes (#2001) * perf: batch update attributes * perf: batch update attributes * 0.0.1-0 * chore: add changeset * chore: revert change --------- Co-authored-by: yunchen.wy <yunchen.wy@antgroup.com> Co-authored-by: wang1212 <mrwang1212@126.com> * chore(release): bump version (#2114) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: huiyu.zjt <Alexzjt@users.noreply.github.com> Co-authored-by: yunchen.wy <yunchen.wy@antgroup.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This change removes the
rbushdependency and all related logic from the codebase. TheRBushNodecomponent has been deleted, and theCanvasRendererPluginandSelectablePluginhave been refactored to use existing methods for spatial queries. The documentation has also been updated to reflect these changes.PR created automatically by Jules for task 11034485319737824727 started by @wang1212