Skip to content

Conversation

@wang1212
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English docs: remove legacy configuration
🇨🇳 Chinese docs: 删除遗留配置

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2025

⚠️ No Changeset found

Latest commit: 0c8d380

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @wang1212, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on optimizing the documentation site by removing outdated and unused configurations. It cleans up global dependencies that are no longer required and eliminates a legacy configuration block, contributing to a leaner and more maintainable site setup.

Highlights

  • Global Dependencies Cleanup: Removed several require statements for @antv/g-plugin-svg-renderer, @antv/g-components, @antv/g-image-exporter, and @antv/g-pattern from the global window object in site/.dumi/global.ts, streamlining the site's global scope.
  • Configuration Removal: The petercat configuration block, including its show and token properties, was removed from site/.dumirc.ts, indicating the deprecation or removal of this specific site configuration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@wang1212 wang1212 merged commit 4b06d44 into master Dec 22, 2025
4 checks passed
@wang1212 wang1212 deleted the docs/fix branch December 22, 2025 11:16
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request focuses on removing legacy configurations, which is a great maintenance task. The removal of unused global dependencies in site/.dumi/global.ts cleans up the project. Most notably, the removal of the petercat configuration in site/.dumirc.ts also removes a hardcoded token, which is a significant security improvement. The changes are positive for the health and security of the codebase.

I am having trouble creating individual review comments. Click here to see my feedback.

site/.dumirc.ts (45-48)

security-high high

Removing this hardcoded token is an excellent security improvement. Hardcoding secrets like API tokens in source code is a significant security risk because it exposes them to anyone with access to the repository. The best practice is to manage secrets using environment variables or a dedicated secrets management service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants