-
Notifications
You must be signed in to change notification settings - Fork 230
Release #2108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* refactor: sub-package governance * refactor: type error * refactor: merge @antv/g-plugin-canvas-path-generator into @antv/g-canvas * chore: remove legacy code * chore: fix build error * refactor: merge @antv/g-plugin-canvas-picker into @antv/g-canvas * refactor: merge @antv/g-plugin-image-loader into @antv/g-lite * refactor: merge @antv/g-plugin-html-renderer into @antv/g-lite * refactor: merge @antv/g-plugin-dom-interaction into @antv/g-lite * refactor: merge @antv/g-plugin-canvas-renderer into @antv/g-canvas * refactor: merge @antv/g-plugin-svg-picker into @antv/g-svg * refactor: merge @antv/g-plugin-svg-renderer into @antv/g-svg * refactor: merge @antv/g-plugin-mobile-interaction into @antv/g-lite * refactor: remove package @antv/g-layout-blocklike * refactor: remove package @antv/g-css-typed-om-api * refactor: remove package @antv/g-css-layout-api * refactor: merge @antv/g-plugin-canvaskit-renderer into @antv/g-canvaskit * refactor: merge @antv/g-image-exporter into @antv/g * refactor: merge @antv/g-mobile-canvas-element into @antv/g-mobile-canvas * refactor: remove package @antv/g-gesture * refactor: merge @antv/g-pattern into @antv/g * refactor: merge @antv/g-components into @antv/g * chore: update docs * chore: add changeset
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Summary of ChangesHello @wang1212, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request represents a major refactoring effort focused on improving the project's package governance. The primary goal is to consolidate numerous smaller, single-purpose packages into larger, more cohesive units. This change aims to simplify the overall architecture, reduce dependency overhead, and make the codebase easier to manage and understand for developers. The impact is a cleaner project structure and more straightforward import mechanisms across the board. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant refactoring focused on sub-package governance, merging many smaller packages into larger, more coherent ones like @antv/g, @antv/g-canvas, and @antv/g-svg. This is a great step towards improving maintainability. The changes are mostly consistent across the codebase, with updates to package.json files, import paths, and build configurations.
My review has focused on the correctness and consistency of these large-scale changes. I've found a few points that need attention, primarily concerning the removal of test files and some inconsistencies in the documentation. Please see my detailed comments.
No description provided.