Skip to content

Conversation

@ITHelpDec
Copy link

Most of this has been addressed in an earlier issue, so thank you to @dragon-dreamer and @xxrlzzz.

As it stands, an incomplete join_threads will result in a runtime error, and functionally we need to ensure an else statement is included should update_source not return true.

Our block_start iterator is also unused, so maybe this was a throwback to earlier examples where block_start and block_end were passed recursively?

Good catch, guys / dolls.

ITHelpDec added 3 commits July 4, 2023 12:48
  * libc++abi: terminating, otherwise
  * without this inverted else statement, the code produces incorrect partial sums
  * block_start is not used in algorithm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant