fix[ws]: handle unsupported paths and message types

[Alex-Izquierdo]

We are not handling WS requests for unsupported paths having a 500 unhandled exception

eda-ws_1                 | 2024-01-08 13:50:00,821 daphne.server ERROR    Exception inside application: No route found for path 'api/eda/ws/ansible-rulebookk'.
eda-ws_1                 | Traceback (most recent call last):
eda-ws_1                 |   File "/app/venv/lib64/python3.9/site-packages/django/contrib/staticfiles/handlers.py", line 101, in __call__
eda-ws_1                 |     return await self.application(scope, receive, send)
eda-ws_1                 |   File "/app/venv/lib64/python3.9/site-packages/channels/routing.py", line 62, in __call__
eda-ws_1                 |     return await application(scope, receive, send)
eda-ws_1                 |   File "/app/venv/lib64/python3.9/site-packages/channels/routing.py", line 134, in __call__
eda-ws_1                 |     raise ValueError("No route found for path %r." % path)
eda-ws_1                 | ValueError: No route found for path 'api/eda/ws/ansible-rulebookk'.
eda-ws_1                 | 2024-01-08 13:50:00,822 django.channels.server INFO     WebSocket DISCONNECT /api/eda/ws/ansible-rulebookk [10.89.0.20:52444]

Also I have found a bug where we are not handling unsupported message types.
Jira: https://issues.redhat.com/browse/AAP-19294

[mkanoor]

@Alex-Izquierdo Should we reveal this, it might be better to just close the connection

[mkanoor]

@Alex-Izquierdo @bzwei has a PR which will put authentication on this path #540

[bzwei]

@Alex-Izquierdo
Could HandleRouteNotFoundMiddleware suggested in django/daphne#165 be a more elegant solution?

[Alex-Izquierdo]

@Alex-Izquierdo Could HandleRouteNotFoundMiddleware suggested in django/daphne#165 be a more elegant solution?

Hi @bzwei, I agree. Middleware seems like a good approach too, right now I don't fully understand how that middleware works, and even if we copy it, it probably should have its own tests. Since you are more familiar with this, if you really trust on that code, I have no problem using it, otherwise I would think the current approach is also simpler and effortless.

[bzwei]

@Alex-Izquierdo Could HandleRouteNotFoundMiddleware suggested in django/daphne#165 be a more elegant solution?

Hi @bzwei, I agree. Middleware seems like a good approach too, right now I don't fully understand how that middleware works, and even if we copy it, it probably should have its own tests. Since you are more familiar with this, if you really trust on that code, I have no problem using it, otherwise I would think the current approach is also simpler and effortless.

If this is not urgently needed, I can try out the middleware solution.

[Alex-Izquierdo]

@bzwei Yeah, I don't think it is critical since ansible-rulebook is the only real client of the websockets. Just I noticed that and I thought I could address it easily.