fix: [AAP-65460] handle ssh:// and git+ssh:// URLs in project sync#1484
Open
hsong-rh wants to merge 1 commit intoansible:mainfrom
Open
fix: [AAP-65460] handle ssh:// and git+ssh:// URLs in project sync#1484hsong-rh wants to merge 1 commit intoansible:mainfrom
hsong-rh wants to merge 1 commit intoansible:mainfrom
Conversation
build_url() only recognized git@host:path shorthand as SSH URLs. URLs with ssh:// or git+ssh:// schemes (common for Gitea and self-hosted VCS with non-standard ports) fell through to HTTP credential-embedding logic, corrupting the URL and causing "Permission denied (publickey)" errors. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
/run-e2e |
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1484 +/- ##
==========================================
+ Coverage 91.44% 91.51% +0.06%
==========================================
Files 235 235
Lines 10135 10135
==========================================
+ Hits 9268 9275 +7
+ Misses 867 860 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mkanoor
approved these changes
Feb 19, 2026
Contributor
Author
|
Green e2e test: https://github.com/ansible/eda-server/actions/runs/22197118162 |
kaiokmo
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



https://issues.redhat.com/browse/AAP-65460
Summary
build_url()only recognizedgit@host:pathshorthand as SSH URLsssh://orgit+ssh://schemes (common for Gitea and self-hosted VCS with non-standard ports) fell through to HTTP credential-embedding logic, corrupting the URL and causing "Permission denied (publickey)" errorsssh://andgit+ssh://scheme URLs to preserve them unchanged, matching existing behavior forgit@shorthandTest plan
build_url()coveringssh://,git+ssh://, andssh://with non-standard portsgit_clone()verifying SSH key credential is applied correctly for all SSH URL formatsLocal verification
Verified end-to-end with a local Gitea instance:
podman run -d --name gitea -p 3000:3000 -p 2222:22 gitea/gitea:latest)Source Controlcredential with the private keyssh://git@<host>:2222/admin/test-rulebook.gitand assigned the credential🤖 Generated with Claude Code